From 29e1aa57e108853caaf2dcac84c4c75f19510f34 Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Fri, 8 Sep 2017 11:37:22 +0200 Subject: Ask the schema whether the table and column exist Signed-off-by: Joas Schilling --- lib/private/Repair/Owncloud/SaveAccountsTableData.php | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/lib/private/Repair/Owncloud/SaveAccountsTableData.php b/lib/private/Repair/Owncloud/SaveAccountsTableData.php index ae56004020d..c9e67356fb9 100644 --- a/lib/private/Repair/Owncloud/SaveAccountsTableData.php +++ b/lib/private/Repair/Owncloud/SaveAccountsTableData.php @@ -23,8 +23,6 @@ namespace OC\Repair\Owncloud; -use Doctrine\DBAL\Exception\InvalidFieldNameException; -use Doctrine\DBAL\Exception\TableNotFoundException; use OCP\DB\QueryBuilder\IQueryBuilder; use OCP\IConfig; use OCP\IDBConnection; @@ -86,20 +84,15 @@ class SaveAccountsTableData implements IRepairStep { * @return bool */ protected function shouldRun() { - $query = $this->db->getQueryBuilder(); - $query->select('*') - ->from('accounts') - ->where($query->expr()->isNotNull('user_id')) - ->setMaxResults(1); + $schema = $this->db->createSchema(); - try { - $query->execute(); - return true; - } catch (InvalidFieldNameException $e) { - return false; - } catch (TableNotFoundException $e) { + $tableName = $this->config->getSystemValue('dbtableprefix', 'oc_') . 'accounts'; + if (!$schema->hasTable($tableName)) { return false; } + + $table = $schema->getTable($tableName); + return $table->hasColumn('user_id'); } /** -- cgit v1.2.3