From 82869b6d814560283c0d0771437cbd6f98cd102f Mon Sep 17 00:00:00 2001 From: Morris Jobke Date: Fri, 12 Jan 2018 23:56:25 +0100 Subject: Fix case when overwrite URL is empty during setup Found while testing strict typing for PHP 7+. Signed-off-by: Morris Jobke --- core/Command/Maintenance/UpdateHtaccess.php | 2 +- lib/private/Setup.php | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/core/Command/Maintenance/UpdateHtaccess.php b/core/Command/Maintenance/UpdateHtaccess.php index 4b9c8a72b52..001f07187d6 100644 --- a/core/Command/Maintenance/UpdateHtaccess.php +++ b/core/Command/Maintenance/UpdateHtaccess.php @@ -43,7 +43,7 @@ class UpdateHtaccess extends Command { $output->writeln('.htaccess has been updated'); return 0; } else { - $output->writeln('Error updating .htaccess file, not enough permissions?'); + $output->writeln('Error updating .htaccess file, not enough permissions or "overwrite.cli.url" set to an invalid URL?'); return 1; } } diff --git a/lib/private/Setup.php b/lib/private/Setup.php index 92246e8322e..43fa6c4a117 100644 --- a/lib/private/Setup.php +++ b/lib/private/Setup.php @@ -437,6 +437,9 @@ class Setup { return false; } $webRoot = parse_url($webRoot, PHP_URL_PATH); + if ($webRoot === null) { + return false; + } $webRoot = rtrim($webRoot, '/'); } else { $webRoot = !empty(\OC::$WEBROOT) ? \OC::$WEBROOT : '/'; -- cgit v1.2.3