From 9250704ecb2af58f455169ab8fb92428584e6488 Mon Sep 17 00:00:00 2001
From: Arthur Schiwon <blizzz@owncloud.com>
Date: Wed, 24 Feb 2016 21:11:03 +0100
Subject: add index definitions for comments tables

---
 db_structure.xml | 51 +++++++++++++++++++++++++++++++++++++++++----------
 version.php      |  2 +-
 2 files changed, 42 insertions(+), 11 deletions(-)

diff --git a/db_structure.xml b/db_structure.xml
index b1242171127..acdd2a5a577 100644
--- a/db_structure.xml
+++ b/db_structure.xml
@@ -1541,8 +1541,7 @@
 				<notnull>true</notnull>
 				<length>64</length>
 			</field>
-<!--
-			TODO: finalize indexes when all queries are done
+
 			<index>
 				<name>comments_parent_id_index</name>
 				<unique>false</unique>
@@ -1553,15 +1552,11 @@
 			</index>
 
 			<index>
-				<name>comments_actor_index</name>
+				<name>comments_topmost_parent_id_idx</name>
 				<unique>false</unique>
 				<field>
-					<name>actor_type</name>
-					<sorting>ascending</sorting>
-				</field>
-				<field>
-					<name>actor_id</name>
-					<sorting>ascending</sorting>
+					<name>topmost_parent_id</name>
+					<sorting>descending</sorting>
 				</field>
 			</index>
 
@@ -1580,8 +1575,21 @@
 					<name>creation_timestamp</name>
 					<sorting>descending</sorting>
 				</field>
+				<!-- TODO: check whether this supports a query without creation timestamp -->
+			</index>
+
+			<index>
+				<name>comments_actor_index</name>
+				<unique>false</unique>
+				<field>
+					<name>actor_type</name>
+					<sorting>ascending</sorting>
+				</field>
+				<field>
+					<name>actor_id</name>
+					<sorting>ascending</sorting>
+				</field>
 			</index>
--->
 
 		</declaration>
 
@@ -1626,6 +1634,29 @@
 				<length>64</length>
 			</field>
 
+			<index>
+				<name>comments_marker_user_id_index</name>
+				<unique>false</unique>
+				<field>
+					<name>user_id</name>
+					<sorting>descending</sorting>
+				</field>
+			</index>
+
+			<index>
+				<name>comments_marker_object_index</name>
+				<unique>false</unique>
+				<field>
+					<name>object_type</name>
+					<sorting>ascending</sorting>
+				</field>
+				<field>
+					<name>object_id</name>
+					<sorting>ascending</sorting>
+				</field>
+				<!-- TODO: check whether this supports a query with user_id -->
+			</index>
+
 		</declaration>
 
 	</table>
diff --git a/version.php b/version.php
index 4ae94717c3d..1113196ce33 100644
--- a/version.php
+++ b/version.php
@@ -25,7 +25,7 @@
 // We only can count up. The 4. digit is only for the internal patchlevel to trigger DB upgrades
 // between betas, final and RCs. This is _not_ the public version number. Reset minor/patchlevel
 // when updating major/minor version number.
-$OC_Version = array(9, 0, 0, 13);
+$OC_Version = array(9, 0, 0, 14);
 
 // The human readable string
 $OC_VersionString = '9.0.0 beta 2';
-- 
cgit v1.2.3


From b3ac81f1344634da3027e34000c20b8e13dcad49 Mon Sep 17 00:00:00 2001
From: Arthur Schiwon <blizzz@owncloud.com>
Date: Fri, 26 Feb 2016 01:02:22 +0100
Subject: exchange user_id_key for a unique one.

---
 db_structure.xml | 20 +++++++++++++-------
 version.php      |  2 +-
 2 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/db_structure.xml b/db_structure.xml
index acdd2a5a577..99541a4f901 100644
--- a/db_structure.xml
+++ b/db_structure.xml
@@ -1575,7 +1575,6 @@
 					<name>creation_timestamp</name>
 					<sorting>descending</sorting>
 				</field>
-				<!-- TODO: check whether this supports a query without creation timestamp -->
 			</index>
 
 			<index>
@@ -1635,17 +1634,25 @@
 			</field>
 
 			<index>
-				<name>comments_marker_user_id_index</name>
+				<name>comments_marker_object_index</name>
 				<unique>false</unique>
 				<field>
-					<name>user_id</name>
-					<sorting>descending</sorting>
+					<name>object_type</name>
+					<sorting>ascending</sorting>
+				</field>
+				<field>
+					<name>object_id</name>
+					<sorting>ascending</sorting>
 				</field>
 			</index>
 
 			<index>
-				<name>comments_marker_object_index</name>
-				<unique>false</unique>
+				<name>comments_marker_index</name>
+				<unique>true</unique>
+				<field>
+					<name>user_id</name>
+					<sorting>descending</sorting>
+				</field>
 				<field>
 					<name>object_type</name>
 					<sorting>ascending</sorting>
@@ -1654,7 +1661,6 @@
 					<name>object_id</name>
 					<sorting>ascending</sorting>
 				</field>
-				<!-- TODO: check whether this supports a query with user_id -->
 			</index>
 
 		</declaration>
diff --git a/version.php b/version.php
index 1113196ce33..d7b80142144 100644
--- a/version.php
+++ b/version.php
@@ -25,7 +25,7 @@
 // We only can count up. The 4. digit is only for the internal patchlevel to trigger DB upgrades
 // between betas, final and RCs. This is _not_ the public version number. Reset minor/patchlevel
 // when updating major/minor version number.
-$OC_Version = array(9, 0, 0, 14);
+$OC_Version = array(9, 0, 0, 15);
 
 // The human readable string
 $OC_VersionString = '9.0.0 beta 2';
-- 
cgit v1.2.3