From 5bb4330ea47e1c0839bebaeb9afbf1a1f7a77916 Mon Sep 17 00:00:00 2001 From: Victor Dubiniuk Date: Wed, 2 Oct 2013 00:58:51 +0300 Subject: Fix autoloader regression --- lib/autoloader.php | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/autoloader.php b/lib/autoloader.php index 72041200116..44d19ae0ee2 100644 --- a/lib/autoloader.php +++ b/lib/autoloader.php @@ -77,6 +77,7 @@ class Autoloader { $paths[] = 'private/' . strtolower(str_replace('_', '/', substr($class, 3)) . '.php'); } elseif (strpos($class, 'OC\\') === 0) { $paths[] = 'private/' . strtolower(str_replace('\\', '/', substr($class, 3)) . '.php'); + $paths[] = strtolower(str_replace('\\', '/', substr($class, 3)) . '.php'); } elseif (strpos($class, 'OCP\\') === 0) { $paths[] = 'public/' . strtolower(str_replace('\\', '/', substr($class, 4)) . '.php'); } elseif (strpos($class, 'OCA\\') === 0) { -- cgit v1.2.3 From ceeb22aa5ff354419051b96e94d6239c69d7b206 Mon Sep 17 00:00:00 2001 From: Morris Jobke Date: Wed, 2 Oct 2013 11:25:44 +0200 Subject: fix unit tests --- tests/lib/autoloader.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/lib/autoloader.php b/tests/lib/autoloader.php index b182dc87477..314a8ebee8d 100644 --- a/tests/lib/autoloader.php +++ b/tests/lib/autoloader.php @@ -19,11 +19,11 @@ class AutoLoader extends \PHPUnit_Framework_TestCase { } public function testLeadingSlashOnClassName() { - $this->assertEquals(array('private/files/storage/local.php'), $this->loader->findClass('\OC\Files\Storage\Local')); + $this->assertEquals(array('private/files/storage/local.php', 'files/storage/local.php'), $this->loader->findClass('\OC\Files\Storage\Local')); } public function testNoLeadingSlashOnClassName() { - $this->assertEquals(array('private/files/storage/local.php'), $this->loader->findClass('OC\Files\Storage\Local')); + $this->assertEquals(array('private/files/storage/local.php', 'files/storage/local.php'), $this->loader->findClass('OC\Files\Storage\Local')); } public function testLegacyPath() { @@ -54,7 +54,7 @@ class AutoLoader extends \PHPUnit_Framework_TestCase { } public function testLoadCoreNamespace() { - $this->assertEquals(array('private/foo/bar.php'), $this->loader->findClass('OC\Foo\Bar')); + $this->assertEquals(array('private/foo/bar.php', 'foo/bar.php'), $this->loader->findClass('OC\Foo\Bar')); } public function testLoadCore() { -- cgit v1.2.3 From 013e9c27d2e9647c719b05a5119670d976b46202 Mon Sep 17 00:00:00 2001 From: kondou Date: Wed, 2 Oct 2013 12:21:52 +0200 Subject: Fix require in apps/files/ajax/rawlist.php --- apps/files/ajax/rawlist.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/files/ajax/rawlist.php b/apps/files/ajax/rawlist.php index 531481a84c0..b9890554197 100644 --- a/apps/files/ajax/rawlist.php +++ b/apps/files/ajax/rawlist.php @@ -5,7 +5,7 @@ $RUNTIME_APPTYPES=array('filesystem'); // Init owncloud -require_once 'lib/template.php'; +require_once 'lib/private/template.php'; OCP\JSON::checkLoggedIn(); -- cgit v1.2.3 From feb7028a7845cca43ae5be8edc6000145c7d9cdd Mon Sep 17 00:00:00 2001 From: kondou Date: Wed, 2 Oct 2013 12:45:30 +0200 Subject: Remove require in rawlist.php Thanks @tanghus for pointing out the unneccessity of it. --- apps/files/ajax/rawlist.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/apps/files/ajax/rawlist.php b/apps/files/ajax/rawlist.php index b9890554197..40da32b223a 100644 --- a/apps/files/ajax/rawlist.php +++ b/apps/files/ajax/rawlist.php @@ -3,10 +3,6 @@ // only need filesystem apps $RUNTIME_APPTYPES=array('filesystem'); -// Init owncloud - -require_once 'lib/private/template.php'; - OCP\JSON::checkLoggedIn(); // Load the files -- cgit v1.2.3 From 78c60c25c86e9e00d603e29113fae3eb2f8d1bc7 Mon Sep 17 00:00:00 2001 From: Thomas Müller Date: Wed, 2 Oct 2013 13:00:05 +0200 Subject: only perform files upgrade in case there are actually entries in the old fscache table --- lib/private/files/cache/upgrade.php | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/private/files/cache/upgrade.php b/lib/private/files/cache/upgrade.php index cfb9a117311..e3a46896cbf 100644 --- a/lib/private/files/cache/upgrade.php +++ b/lib/private/files/cache/upgrade.php @@ -192,7 +192,15 @@ class Upgrade { */ static function needUpgrade($user) { $cacheVersion = (int)\OCP\Config::getUserValue($user, 'files', 'cache_version', 4); - return $cacheVersion < 5; + if ($cacheVersion < 5) { + $legacy = new \OC\Files\Cache\Legacy($user); + if ($legacy->hasItems()) { + return true; + } + self::upgradeDone($user); + } + + return false; } /** -- cgit v1.2.3 From 8ce26297b94431e1b08954dce729be596855bb60 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Wed, 2 Oct 2013 17:53:54 +0300 Subject: reduce rounded corners of Share and Versions dropdown --- core/css/share.css | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/css/share.css b/core/css/share.css index 2d6849b4bb1..3dbd06fde14 100644 --- a/core/css/share.css +++ b/core/css/share.css @@ -2,10 +2,10 @@ This file is licensed under the Affero General Public License version 3 or later. See the COPYING-README file. */ - #dropdown { +#dropdown { background:#eee; - border-bottom-left-radius:1em; - border-bottom-right-radius:1em; + border-bottom-left-radius: 5px; + border-bottom-right-radius: 5px; box-shadow:0 1px 1px #777; display:block; margin-right:7em; -- cgit v1.2.3 From c548edd90f334cea26cdebceb2efd576b3461f9c Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Wed, 2 Oct 2013 17:59:38 +0300 Subject: remove box-shadows for header, navigation and controls bar - looks sharper and less washed out --- core/css/styles.css | 5 ----- 1 file changed, 5 deletions(-) diff --git a/core/css/styles.css b/core/css/styles.css index dcdeda8a9c9..06b61f0fa68 100644 --- a/core/css/styles.css +++ b/core/css/styles.css @@ -19,9 +19,6 @@ body { background:#fefefe; font:normal .8em/1.6em "Helvetica Neue",Helvetica,Ari #body-user #header, #body-settings #header { position:fixed; top:0; left:0; right:0; z-index:100; height:45px; line-height:2.5em; background:#1d2d44 url('../img/noise.png') repeat; - -moz-box-shadow:0 0 10px rgba(0, 0, 0, .5); - -webkit-box-shadow:0 0 10px rgba(0, 0, 0, .5); - box-shadow:0 0 10px rgba(0, 0, 0, .5); } #body-login { @@ -164,7 +161,6 @@ input[type="submit"].enabled { background:#66f866; border:1px solid #5e5; -moz-b border-bottom: 1px solid #e7e7e7; z-index: 50; -moz-box-sizing: border-box; box-sizing: border-box; - -moz-box-shadow: 0 -3px 7px #000; -webkit-box-shadow: 0 -3px 7px #000; box-shadow: 0 -3px 7px #000; } #controls .button { display: inline-block; @@ -512,7 +508,6 @@ label.infield { cursor:text !important; top:1.05em; left:.85em; } z-index: 75; height: 100%; background:#383c43 url('../img/noise.png') repeat; - -moz-box-shadow:0 0 7px #000; -webkit-box-shadow:0 0 7px #000; box-shadow:0 0 7px #000; overflow:hidden; box-sizing:border-box; -moz-box-sizing:border-box; /* prevent ugly selection effect on accidental selection */ -webkit-user-select: none; -moz-user-select: none; -ms-user-select: none; user-select: none; -- cgit v1.2.3 From 9853b33420e170e45833c6d51aa84d27eab9cd5d Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Wed, 2 Oct 2013 18:04:08 +0300 Subject: reduce rounded corners of New dropdown --- apps/files/css/files.css | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/apps/files/css/files.css b/apps/files/css/files.css index b3ecd1dab93..9685548bdfc 100644 --- a/apps/files/css/files.css +++ b/apps/files/css/files.css @@ -16,7 +16,10 @@ display:none; position:fixed; min-width:7em; z-index:10; padding:.5em; padding-bottom:0; margin-top:.075em; margin-left:-.5em; text-align:left; - background:#f8f8f8; border:1px solid #ddd; border-radius:10px; border-top-left-radius:0; + background: #f8f8f8; + border: 1px solid #ddd; + border-radius: 5px; + border-top-left-radius: 0; box-shadow:0 2px 7px rgba(170,170,170,.4); } #new>ul>li { height:36px; margin:.3em; padding-left:3em; padding-bottom:0.1em; -- cgit v1.2.3 From 5feaa557796fbe759bb4b16d432cf61ca72218a0 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Wed, 2 Oct 2013 18:27:39 +0300 Subject: simplify From Link icon in New menu --- apps/files/templates/index.php | 2 +- core/img/places/link.png | Bin 0 -> 1093 bytes core/img/places/link.svg | 12 ++++++++++++ 3 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 core/img/places/link.png create mode 100644 core/img/places/link.svg diff --git a/apps/files/templates/index.php b/apps/files/templates/index.php index 96a80738989..50a2720e1c0 100644 --- a/apps/files/templates/index.php +++ b/apps/files/templates/index.php @@ -9,7 +9,7 @@ data-type='file'>

t('Text file'));?>

  • t('Folder'));?>

  • -
  • t('From link'));?>

  • diff --git a/core/img/places/link.png b/core/img/places/link.png new file mode 100644 index 00000000000..44b7e199a72 Binary files /dev/null and b/core/img/places/link.png differ diff --git a/core/img/places/link.svg b/core/img/places/link.svg new file mode 100644 index 00000000000..8784ebc1456 --- /dev/null +++ b/core/img/places/link.svg @@ -0,0 +1,12 @@ + + + + + image/svg+xml + + + + + + + -- cgit v1.2.3 From 81b4904c78f98d3c42c85463488eaa1765c13c28 Mon Sep 17 00:00:00 2001 From: raghunayyar Date: Wed, 2 Oct 2013 21:13:07 +0530 Subject: File Selected on Click instead of download. --- apps/files/css/files.css | 6 ++++++ apps/files/templates/part.list.php | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/apps/files/css/files.css b/apps/files/css/files.css index b3ecd1dab93..82b3024231b 100644 --- a/apps/files/css/files.css +++ b/apps/files/css/files.css @@ -228,6 +228,12 @@ table td.filename form { font-size:.85em; margin-left:3em; margin-right:3em; } -webkit-transition:background-image 500ms; -moz-transition:background-image 500ms; -o-transition:background-image 500ms; transition:background-image 500ms; } +#fileList tr td.filename .name { + position: absolute; + width: 100%; + height: 50px; +} + #uploadsize-message,#delete-confirm { display:none; } /* File actions */ diff --git a/apps/files/templates/part.list.php b/apps/files/templates/part.list.php index 1e4d4d11c98..ed3e3a2d94a 100644 --- a/apps/files/templates/part.list.php +++ b/apps/files/templates/part.list.php @@ -31,7 +31,7 @@ $totalsize = 0; ?> - + -- cgit v1.2.3 From 4a5f3442b5cab84c5cadc65567f15e56b258cc20 Mon Sep 17 00:00:00 2001 From: raghunayyar Date: Wed, 2 Oct 2013 21:40:34 +0530 Subject: Closes Label inside the a tag for not hiding the fileactions. --- apps/files/css/files.css | 2 +- apps/files/templates/part.list.php | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/files/css/files.css b/apps/files/css/files.css index 82b3024231b..0269978374b 100644 --- a/apps/files/css/files.css +++ b/apps/files/css/files.css @@ -228,7 +228,7 @@ table td.filename form { font-size:.85em; margin-left:3em; margin-right:3em; } -webkit-transition:background-image 500ms; -moz-transition:background-image 500ms; -o-transition:background-image 500ms; transition:background-image 500ms; } -#fileList tr td.filename .name { +#fileList tr td.filename a.name label { position: absolute; width: 100%; height: 50px; diff --git a/apps/files/templates/part.list.php b/apps/files/templates/part.list.php index ed3e3a2d94a..4e37cfb379f 100644 --- a/apps/files/templates/part.list.php +++ b/apps/files/templates/part.list.php @@ -31,7 +31,9 @@ $totalsize = 0; ?> - + + + -- cgit v1.2.3 From 99fa4898fd59e3f55f2df1d800a9b158575243c3 Mon Sep 17 00:00:00 2001 From: Morris Jobke Date: Wed, 2 Oct 2013 18:27:55 +0200 Subject: just fix whitespace stuff --- core/css/share.css | 130 +++++++++++++++++++++++++++-------------------------- 1 file changed, 66 insertions(+), 64 deletions(-) diff --git a/core/css/share.css b/core/css/share.css index 3dbd06fde14..10936e56520 100644 --- a/core/css/share.css +++ b/core/css/share.css @@ -3,94 +3,96 @@ See the COPYING-README file. */ #dropdown { - background:#eee; + background:#eee; border-bottom-left-radius: 5px; border-bottom-right-radius: 5px; - box-shadow:0 1px 1px #777; - display:block; - margin-right:7em; - position:absolute; - right:0; - width:19em; - z-index:500; - padding:1em; - } - - #shareWithList { - list-style-type:none; - padding:.5em; - } - - #shareWithList li { - padding-top:.1em; - } - - #shareWithList li:first-child { - white-space:normal; - } - - #shareWithList .cruds { - margin-left:-10px; - } + box-shadow:0 1px 1px #777; + display:block; + margin-right:7em; + position:absolute; + right:0; + width:19em; + z-index:500; + padding:1em; +} + +#shareWithList { + list-style-type:none; + padding:.5em; +} + +#shareWithList li { + padding-top:.1em; +} + +#shareWithList li:first-child { + white-space:normal; +} + +#shareWithList .cruds { + margin-left:-10px; +} #shareWithList .unshare img, #shareWithList .showCruds img { vertical-align:text-bottom; /* properly align icons */ } - #dropdown label { - font-weight:400; - } +#dropdown label { + font-weight:400; +} - #dropdown input[type="checkbox"] { - margin:0 .2em 0 .5em; - } +#dropdown input[type="checkbox"] { + margin:0 .2em 0 .5em; +} - a.showCruds { - display:inline; - opacity:.5; - } +a.showCruds { + display:inline; + opacity:.5; +} - a.unshare { - display:inline; - float:right; - opacity:.5; - padding:.3em 0 0 .3em !important; +a.unshare { + display:inline; + float:right; + opacity:.5; + padding:.3em 0 0 .3em !important; margin-top:-5px; - } +} - #link { - border-top:1px solid #ddd; - padding-top:.5em; - } +#link { + border-top:1px solid #ddd; + padding-top:.5em; +} #dropdown input[type="text"],#dropdown input[type="password"] { - width:90%; + width:90%; } #dropdown form { - font-size: 100%; - margin-left: 0; - margin-right: 0; + font-size: 100%; + margin-left: 0; + margin-right: 0; } #linkText,#linkPass,#expiration { - display:none; - } + display:none; +} - #link #showPassword img { - padding-left:.3em; - width:12px; - } +#link #showPassword img { + padding-left:.3em; + width:12px; +} - .reshare,#link label,#expiration label { - padding-left:.5em; - } +.reshare,#link label,#expiration label { + padding-left:.5em; +} - a.showCruds:hover,a.unshare:hover { - opacity:1; - } +a.showCruds:hover,a.unshare:hover { + opacity:1; +} -.reshare { white-space:normal; } /* fix shared by text going out of box */ +.reshare { /* fix shared by text going out of box */ + white-space:normal; +} .ui-autocomplete { /* limit dropdown height to 4 1/2 entries */ max-height:103px; -- cgit v1.2.3 From 0d5653c6b1a5ef78f3619a7937c20a795797a499 Mon Sep 17 00:00:00 2001 From: raghunayyar Date: Wed, 2 Oct 2013 22:11:03 +0530 Subject: Takes nametext inside the anchor tag to fix the issue completely. --- apps/files/templates/part.list.php | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/apps/files/templates/part.list.php b/apps/files/templates/part.list.php index 4e37cfb379f..0679da334de 100644 --- a/apps/files/templates/part.list.php +++ b/apps/files/templates/part.list.php @@ -30,18 +30,15 @@ $totalsize = 0; ?> + + + - + + - - - - - - - -- cgit v1.2.3 From d09b1553d0356adb894854884c672e3696a74f4e Mon Sep 17 00:00:00 2001 From: Vincent Petry Date: Thu, 3 Oct 2013 11:30:55 +0200 Subject: Fixed syntax error in array --- core/ajax/share.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/ajax/share.php b/core/ajax/share.php index 9b282b2b94a..f55a79a9034 100644 --- a/core/ajax/share.php +++ b/core/ajax/share.php @@ -104,7 +104,7 @@ if (isset($_POST['action']) && isset($_POST['itemType']) && isset($_POST['itemSo } // don't send a mail to the user who shared the file - array_diff($recipientList, [\OCP\User::getUser()]); + array_diff($recipientList, array(\OCP\User::getUser())); // send mail to all recipients with an email address foreach ($recipientList as $recipient) { -- cgit v1.2.3