From b1a4b239b84748091c11f94fea7255d96aea301b Mon Sep 17 00:00:00 2001 From: nextcloud-command Date: Thu, 4 Nov 2021 09:17:46 +0000 Subject: Update psalm baseline Signed-off-by: GitHub --- build/psalm-baseline.xml | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/build/psalm-baseline.xml b/build/psalm-baseline.xml index 156599e8b41..bdcdeb5796a 100644 --- a/build/psalm-baseline.xml +++ b/build/psalm-baseline.xml @@ -4261,11 +4261,6 @@ [] - - - $bp - - $maxPreviewImage @@ -4305,11 +4300,6 @@ $provider->getThumbnail($file, $maxWidth, $maxHeight) - - - $bp - - $second @@ -4332,11 +4322,6 @@ string - - - $svg - - \RedisCluster::OPT_SLAVE_FAILOVER @@ -4982,10 +4967,6 @@ $isWritable - - get_class($resource) === 'GdImage' - get_class($this->resource) === 'GdImage' - -- cgit v1.2.3 From d6152bf98d4a9c86b65536a8be99cf2f64fbde16 Mon Sep 17 00:00:00 2001 From: John Molakvoæ Date: Thu, 4 Nov 2021 10:24:13 +0100 Subject: Fix psalm MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: John Molakvoæ --- lib/private/Files/View.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/private/Files/View.php b/lib/private/Files/View.php index 113290e2686..f2d91065b9a 100644 --- a/lib/private/Files/View.php +++ b/lib/private/Files/View.php @@ -1082,7 +1082,7 @@ class View { * @param string $type * @param string $path * @param bool $raw - * @return bool|null|string + * @return bool|string */ public function hash($type, $path, $raw = false) { $postFix = (substr($path, -1) === '/') ? '/' : ''; @@ -1104,7 +1104,7 @@ class View { return $storage->hash($type, $internalPath, $raw); } } - return null; + return false; } /** -- cgit v1.2.3 From 421d8ac4b3ede4b67ed7ffeecbf58f7d7ca6d0a6 Mon Sep 17 00:00:00 2001 From: John Molakvoæ Date: Thu, 4 Nov 2021 11:42:34 +0100 Subject: Add branch-suffix to update-psalm-baseline PR creation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: John Molakvoæ --- .github/workflows/update-psalm-baseline.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/update-psalm-baseline.yml b/.github/workflows/update-psalm-baseline.yml index f2b761aa602..181148a6c8b 100644 --- a/.github/workflows/update-psalm-baseline.yml +++ b/.github/workflows/update-psalm-baseline.yml @@ -42,6 +42,8 @@ jobs: author: nextcloud-command signoff: true branch: automated/noid/psalm-baseline-update + # Make sure we can open multiple PRs + branch-suffix: timestamp title: '[Automated] Update psalm-baseline.xml' body: | Auto-generated update psalm-baseline.xml with fixed psalm warnings -- cgit v1.2.3