From d4de77afb9bdff57985863b6adc8a37d6d198807 Mon Sep 17 00:00:00 2001
From: "John Molakvoæ (skjnldsv)" <skjnldsv@protonmail.com>
Date: Thu, 19 Jul 2018 23:28:46 +0200
Subject: No remote note and various fixes
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
---
 core/js/sharedialogshareelistview.js | 3 +++
 core/js/sharedialogview.js           | 8 --------
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/core/js/sharedialogshareelistview.js b/core/js/sharedialogshareelistview.js
index a9704155394..823c49e7e65 100644
--- a/core/js/sharedialogshareelistview.js
+++ b/core/js/sharedialogshareelistview.js
@@ -125,6 +125,7 @@
 					'    <input id="expirationDatePicker-{{cid}}-{{shareId}}" class="datepicker" type="text" placeholder="{{expirationDatePlaceholder}}" value="{{#if hasExpireDate}}{{expireDate}}{{else}}{{defaultExpireDate}}{{/if}}" />' +
 					'</span>' +
 				'</li>' +
+				'{{#if isNoteAvailable}}' +
 				'<li>' +
 					'<a href="#" class="share-add"><span class="icon-loading-small hidden"></span>' +
 					'	<span class="icon icon-edit"></span>' +
@@ -138,6 +139,7 @@
 					'	<input type="submit" class="icon-confirm share-note-submit" value="" id="add-note-{{shareId}}" />' +
 					'</span>' +
 				'</li>' +
+				'{{/if}}' +
 				'<li>' +
 					'<a href="#" class="unshare"><span class="icon-loading-small hidden"></span><span class="icon icon-delete"></span><span>{{unshareLabel}}</span></a>' +
 				'</li>' +
@@ -276,6 +278,7 @@
 				modSeed: shareType !== OC.Share.SHARE_TYPE_USER && (shareType !== OC.Share.SHARE_TYPE_CIRCLE || shareWithAvatar),
 				isRemoteShare: shareType === OC.Share.SHARE_TYPE_REMOTE,
 				isRemoteGroupShare: shareType === OC.Share.SHARE_TYPE_REMOTE_GROUP,
+				isNoteAvailable: shareType !== OC.Share.SHARE_TYPE_REMOTE && shareType !== OC.Share.SHARE_TYPE_REMOTE_GROUP,
 				isMailShare: shareType === OC.Share.SHARE_TYPE_EMAIL,
 				isCircleShare: shareType === OC.Share.SHARE_TYPE_CIRCLE,
 				isFileSharedByMail: shareType === OC.Share.SHARE_TYPE_EMAIL && !this.model.isFolder(),
diff --git a/core/js/sharedialogview.js b/core/js/sharedialogview.js
index 60e9211752c..9fa1847d3d5 100644
--- a/core/js/sharedialogview.js
+++ b/core/js/sharedialogview.js
@@ -58,9 +58,6 @@
 		/** @type {object} **/
 		linkShareView: undefined,
 
-		/** @type {object} **/
-		expirationView: undefined,
-		
 		/** @type {object} **/
 		shareeListView: undefined,
 
@@ -104,14 +101,12 @@
 
 			var subViewOptions = {
 				model: this.model,
-				parent: this,
 				configModel: this.configModel
 			};
 
 			var subViews = {
 				resharerInfoView: 'ShareDialogResharerInfoView',
 				linkShareView: 'ShareDialogLinkShareView',
-				expirationView: 'ShareDialogExpirationView',
 				shareeListView: 'ShareDialogShareeListView'
 			};
 
@@ -671,9 +666,6 @@
 			this.linkShareView.$el = this.$el.find('.linkShareView');
 			this.linkShareView.render();
 
-			this.expirationView.$el = this.$el.find('.expirationView');
-			this.expirationView.render();
-
 			this.shareeListView.$el = this.$el.find('.shareeListView');
 			this.shareeListView.render();
 
-- 
cgit v1.2.3