From fc3ce8441e3a33b312fca3ea352ce1297a51a37d Mon Sep 17 00:00:00 2001 From: Morris Jobke Date: Tue, 28 Jul 2015 14:20:55 +0200 Subject: tests for _parseTime with hex and empty strings --- core/js/share.js | 4 ++++ core/js/tests/specs/shareSpec.js | 2 ++ 2 files changed, 6 insertions(+) diff --git a/core/js/share.js b/core/js/share.js index 94833a8d915..2f126eca32c 100644 --- a/core/js/share.js +++ b/core/js/share.js @@ -772,6 +772,10 @@ OC.Share={ */ _parseTime: function(time) { if (_.isString(time)) { + // skip empty strings and hex values + if (time === '' || (time.length > 1 && time[0] === '0' && time[1] === 'x')) { + return null; + } time = parseInt(time, 10); if(isNaN(time)) { time = null; diff --git a/core/js/tests/specs/shareSpec.js b/core/js/tests/specs/shareSpec.js index 22632a2bd2e..eaeba79797c 100644 --- a/core/js/tests/specs/shareSpec.js +++ b/core/js/tests/specs/shareSpec.js @@ -844,6 +844,8 @@ describe('OC.Share tests', function() { [ 123456 , 123456], ['0123456', 123456], ['abcdefg', null], + ['0x12345', null], + [ '', null], ], function(value) { expect(OC.Share._parseTime(value[0])).toEqual(value[1]); }); -- cgit v1.2.3