From 7b72424a39688adbfd382f63899b200a3170884f Mon Sep 17 00:00:00 2001 From: Thomas Mueller Date: Fri, 28 Dec 2012 22:14:32 +0100 Subject: Revert "fixed max possible upload size for files app in admin screen" This reverts commit 7f2208b9a11f608e7d726bf426fe4c2a672e058a. Conflicts: apps/files/admin.php --- apps/files/admin.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'apps/files/admin.php') diff --git a/apps/files/admin.php b/apps/files/admin.php index 80fd4f4e4a5..25645a4bcc9 100644 --- a/apps/files/admin.php +++ b/apps/files/admin.php @@ -30,11 +30,8 @@ OCP\User::checkAdminUser(); $htaccessWorking=(getenv('htaccessWorking')=='true'); $upload_max_filesize = OCP\Util::computerFileSize(ini_get('upload_max_filesize')); -$upload_max_filesize_possible = OCP\Util::computerFileSize(get_cfg_var('upload_max_filesize')); $post_max_size = OCP\Util::computerFileSize(ini_get('post_max_size')); -$post_max_size_possible = OCP\Util::computerFileSize(get_cfg_var('post_max_size')); $maxUploadFilesize = OCP\Util::humanFileSize(min($upload_max_filesize, $post_max_size)); -$maxUploadFilesizePossible = OCP\Util::humanFileSize(min($upload_max_filesize_possible, $post_max_size_possible)); if($_POST && OC_Util::isCallRegistered()) { if(isset($_POST['maxUploadSize'])) { if(($setMaxSize = OC_Files::setUploadLimit(OCP\Util::computerFileSize($_POST['maxUploadSize']))) !== false) { @@ -60,7 +57,7 @@ $htaccessWritable=is_writable(OC::$SERVERROOT.'/.htaccess'); $tmpl = new OCP\Template( 'files', 'admin' ); $tmpl->assign( 'uploadChangable', $htaccessWorking and $htaccessWritable ); $tmpl->assign( 'uploadMaxFilesize', $maxUploadFilesize); -$tmpl->assign( 'maxPossibleUploadSize', $maxUploadFilesizePossible); +$tmpl->assign( 'maxPossibleUploadSize', OCP\Util::humanFileSize(PHP_INT_MAX)); $tmpl->assign( 'allowZipDownload', $allowZipDownload); $tmpl->assign( 'maxZipInputSize', $maxZipInputSize); return $tmpl->fetchPage(); -- cgit v1.2.3 From a3206b4e975082216d143c79edf379703317da20 Mon Sep 17 00:00:00 2001 From: Thomas Mueller Date: Fri, 28 Dec 2012 21:57:05 +0100 Subject: only show the max possible upload of 2GB on a 32 bit system. for a 64 bit system we have no such limitation refs #856 Conflicts: apps/files/templates/admin.php --- apps/files/admin.php | 2 ++ apps/files/templates/admin.php | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) (limited to 'apps/files/admin.php') diff --git a/apps/files/admin.php b/apps/files/admin.php index 25645a4bcc9..f747f8645f6 100644 --- a/apps/files/admin.php +++ b/apps/files/admin.php @@ -57,6 +57,8 @@ $htaccessWritable=is_writable(OC::$SERVERROOT.'/.htaccess'); $tmpl = new OCP\Template( 'files', 'admin' ); $tmpl->assign( 'uploadChangable', $htaccessWorking and $htaccessWritable ); $tmpl->assign( 'uploadMaxFilesize', $maxUploadFilesize); +// max possible makes only sense on a 32 bit system +$tmpl->assign( 'displayMaxPossibleUploadSize', PHP_INT_SIZE===4); $tmpl->assign( 'maxPossibleUploadSize', OCP\Util::humanFileSize(PHP_INT_MAX)); $tmpl->assign( 'allowZipDownload', $allowZipDownload); $tmpl->assign( 'maxZipInputSize', $maxZipInputSize); diff --git a/apps/files/templates/admin.php b/apps/files/templates/admin.php index 0de12edcba5..ad69b5519d9 100644 --- a/apps/files/templates/admin.php +++ b/apps/files/templates/admin.php @@ -6,7 +6,10 @@ '/> - (t('max. possible: '); echo $_['maxPossibleUploadSize'] ?>)
+ + (t('max. possible: '); echo $_['maxPossibleUploadSize'] ?>) + +