From df75a6e5f37d4dbd1fe6abc0cdfb27037ffd1c99 Mon Sep 17 00:00:00 2001
From: Joas Schilling <nickvergessen@gmx.de>
Date: Mon, 26 Jan 2015 10:45:49 +0100
Subject: Only update favorite icon if the operation was successful

Also shows a notification in case an error occured on updating the tags
---
 apps/files/js/tagsplugin.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'apps/files/js')

diff --git a/apps/files/js/tagsplugin.js b/apps/files/js/tagsplugin.js
index 27ab3eced04..b00aacfba57 100644
--- a/apps/files/js/tagsplugin.js
+++ b/apps/files/js/tagsplugin.js
@@ -105,12 +105,12 @@
 					} else {
 						tags.push(OC.TAG_FAVORITE);
 					}
-					toggleStar($actionEl, !isFavorite);
 
 					self.applyFileTags(
 						dir + '/' + fileName,
 						tags
 					).then(function(result) {
+						toggleStar($actionEl, !isFavorite);
 						// response from server should contain updated tags
 						var newTags = result.tags;
 						if (_.isUndefined(newTags)) {
@@ -171,6 +171,8 @@
 				}),
 				dataType: 'json',
 				type: 'POST'
+			}).fail(function() {
+				OC.Notification.showTemporary(t('files', 'An error occurred while trying to update the tags'));
 			});
 		}
 	};
-- 
cgit v1.2.3