From ddc53a9046909b16d551be0bf582dbde6c32745e Mon Sep 17 00:00:00 2001
From: Robin Appelman <robin@icewind.nl>
Date: Thu, 4 May 2023 18:27:00 +0200
Subject: minor fixes for get/put

Signed-off-by: Robin Appelman <robin@icewind.nl>
---
 apps/files/lib/Command/Get.php | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

(limited to 'apps/files/lib/Command/Get.php')

diff --git a/apps/files/lib/Command/Get.php b/apps/files/lib/Command/Get.php
index 29edefa1cfb..7bdb4cb59ee 100644
--- a/apps/files/lib/Command/Get.php
+++ b/apps/files/lib/Command/Get.php
@@ -43,8 +43,8 @@ class Get extends Command {
 		$this
 			->setName('files:get')
 			->setDescription('Get the contents of a file')
-			->addArgument('file', InputArgument::REQUIRED, "File id or path")
-			->addArgument('output', InputArgument::OPTIONAL, "Target file to output to, defaults to STDOUT");
+			->addArgument('file', InputArgument::REQUIRED, "Source file id or Nextcloud path")
+			->addArgument('output', InputArgument::OPTIONAL, "Target local file to output to, defaults to STDOUT");
 	}
 
 	public function execute(InputInterface $input, OutputInterface $output): int {
@@ -68,7 +68,16 @@ class Get extends Command {
 				return 1;
 			}
 			$source = $node->fopen('r');
-			$target = (!$outputName || $outputName === '-') ? STDOUT : fopen($outputName, 'w');
+			if (!$source) {
+				$output->writeln("<error>Failed to open $fileInput for reading</error>");
+				return 1;
+			}
+			$target = ($outputName === null || $outputName === '-') ? STDOUT : fopen($outputName, 'w');
+			if (!$target) {
+				$output->writeln("<error>Failed to open $outputName for reading</error>");
+				return 1;
+			}
+
 			stream_copy_to_stream($source, $target);
 			return 0;
 		} else {
-- 
cgit v1.2.3