From 5e9ca79788fba962418865c0431d25a0a2dc89f7 Mon Sep 17 00:00:00 2001 From: Roeland Jago Douma Date: Tue, 13 Oct 2015 14:26:14 +0200 Subject: Do not calculate non essential info There is no need to calculate a human readable date on the server side. We supply the mtime and a client can easily convert that himself if needed. This is already done most of the time since the date is often not in the exact right format. There is also no need to attach icon info. We have that available in javascript. And else the client should get the right icon based on the mimetype for its platform. * Updated tests --- apps/files/lib/helper.php | 2 -- 1 file changed, 2 deletions(-) (limited to 'apps/files/lib') diff --git a/apps/files/lib/helper.php b/apps/files/lib/helper.php index 6bfdc0a095c..fb14cea731f 100644 --- a/apps/files/lib/helper.php +++ b/apps/files/lib/helper.php @@ -137,10 +137,8 @@ class Helper { $entry['id'] = $i['fileid']; $entry['parentId'] = $i['parent']; - $entry['date'] = \OCP\Util::formatDate($i['mtime']); $entry['mtime'] = $i['mtime'] * 1000; // only pick out the needed attributes - $entry['icon'] = \OCA\Files\Helper::determineIcon($i); if (\OC::$server->getPreviewManager()->isAvailable($i)) { $entry['isPreviewAvailable'] = true; } -- cgit v1.2.3