From b84820387c58e3ba5fd680ac5a6a6836934a3561 Mon Sep 17 00:00:00 2001 From: Ferdinand Thiessen Date: Thu, 30 May 2024 18:44:02 +0200 Subject: fix(files): Only execute default action if there is an action to perform Some files do not have a default action (can not be viewed and only downloaded). If the `openfile` query is set on them the `handleOpenFile` will throw an error. Signed-off-by: Ferdinand Thiessen Signed-off-by: nextcloud-command --- apps/files/src/components/FilesListVirtual.vue | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) (limited to 'apps/files') diff --git a/apps/files/src/components/FilesListVirtual.vue b/apps/files/src/components/FilesListVirtual.vue index d31330f0950..50b42b3f094 100644 --- a/apps/files/src/components/FilesListVirtual.vue +++ b/apps/files/src/components/FilesListVirtual.vue @@ -274,14 +274,18 @@ export default defineComponent({ logger.debug('Opening file ' + node.path, { node }) this.openFileId = fileId - getFileActions() - .filter(action => !action.enabled || action.enabled([node], this.currentView)) + const defaultAction = getFileActions() + // Get only default actions (visible and hidden) + .filter(action => !!action?.default) + // Find actions that are either always enabled or enabled for the current node + .filter((action) => !action.enabled || action.enabled([node], this.currentView)) + // Sort enabled default actions by order .sort((a, b) => (a.order || 0) - (b.order || 0)) - .filter(action => !!action?.default)[0].exec(node, this.currentView, this.currentFolder.path) - }, - - getFileId(node) { - return node.fileid + // Get the first one + .at(0) + // Some file types do not have a default action (e.g. they can only be downloaded) + // So if there is an enabled default action, so execute it + defaultAction?.exec(node, this.currentView, this.currentFolder.path) }, onDragOver(event: DragEvent) { -- cgit v1.2.3