From 1ae68047eaa0662d4e57501bf84a57d5b28c3894 Mon Sep 17 00:00:00 2001 From: Daniel Kesselberg Date: Mon, 20 May 2019 17:54:45 +0200 Subject: Allow hidden smb shares A hidden smb share ends with $. This patch changes the placeholder detection to allow shares with $ at the end. Signed-off-by: Daniel Kesselberg --- .../tests/Config/PlaceholderSubstituteTest.php | 47 ++++++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 apps/files_external/tests/Config/PlaceholderSubstituteTest.php (limited to 'apps/files_external/tests') diff --git a/apps/files_external/tests/Config/PlaceholderSubstituteTest.php b/apps/files_external/tests/Config/PlaceholderSubstituteTest.php new file mode 100644 index 00000000000..95ef8abda9b --- /dev/null +++ b/apps/files_external/tests/Config/PlaceholderSubstituteTest.php @@ -0,0 +1,47 @@ + + * + * @author Daniel Kesselberg + * + * @license GNU AGPL version 3 or any later version + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as + * published by the Free Software Foundation, either version 3 of the + * License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +namespace OCA\files_external\tests\Config; + +use OC_Mount_Config; +use Test\TestCase; + +class PlaceholderSubstituteTest extends TestCase { + + public function dataArePlaceholdersSubstituted(): array { + return [ + ['smb_$user', false], + ['hidden_share$', true], + ]; + } + + /** + * @dataProvider dataArePlaceholdersSubstituted + * @param string|array $option + * @param bool $expected + */ + public function testArePlaceholdersSubstituted($option, $expected): void { + $this->assertSame($expected, OC_Mount_Config::arePlaceholdersSubstituted($option)); + } + +} -- cgit v1.2.3