From b464469bc1a93ff4c0034d5a180361826c178cfc Mon Sep 17 00:00:00 2001 From: Marcel Klehr Date: Mon, 24 Mar 2025 15:39:29 +0100 Subject: perf(sharing): Use oc_share.{item_type, share_type} IN instead of OR equals to improve performance by using the db index Signed-off-by: Marcel Klehr --- apps/files_sharing/lib/OrphanHelper.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'apps/files_sharing/lib/OrphanHelper.php') diff --git a/apps/files_sharing/lib/OrphanHelper.php b/apps/files_sharing/lib/OrphanHelper.php index 4a52af0406c..6e070f1446b 100644 --- a/apps/files_sharing/lib/OrphanHelper.php +++ b/apps/files_sharing/lib/OrphanHelper.php @@ -58,8 +58,7 @@ class OrphanHelper { $query = $this->connection->getQueryBuilder(); $query->select('id', 'file_source', 'uid_owner', 'file_target') ->from('share') - ->where($query->expr()->eq('item_type', $query->createNamedParameter('file'))) - ->orWhere($query->expr()->eq('item_type', $query->createNamedParameter('folder'))); + ->where($query->expr()->in('item_type', $query->createNamedParameter(['file', 'folder'], IQueryBuilder::PARAM_STR_ARRAY))); $result = $query->executeQuery(); while ($row = $result->fetch()) { yield [ -- cgit v1.2.3