From 1672ff3bef9c44e5626c602e62090c18784a7b61 Mon Sep 17 00:00:00 2001 From: Roeland Jago Douma Date: Sun, 5 Jan 2020 15:51:16 +0100 Subject: Do not use $_GET The appframework is more than capable of handling this properly. Signed-off-by: Roeland Jago Douma --- apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'apps/files_sharing/tests/Controller') diff --git a/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php b/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php index 8c0c5b1e41c..1fb14ad9b8f 100644 --- a/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php +++ b/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php @@ -271,9 +271,12 @@ class ShareesAPIControllerTest extends TestCase { ->setMethods(['isRemoteSharingAllowed', 'shareProviderExists', 'isRemoteGroupSharingAllowed']) ->getMock(); + $expectedShareTypes = $shareTypes; + sort($expectedShareTypes); + $this->collaboratorSearch->expects($this->once()) ->method('search') - ->with($search, $shareTypes, $this->anything(), $perPage, $perPage * ($page -1)) + ->with($search, $expectedShareTypes, $this->anything(), $perPage, $perPage * ($page -1)) ->willReturn([[], false]); $sharees->expects($this->any()) @@ -398,7 +401,7 @@ class ShareesAPIControllerTest extends TestCase { $this->assertSame($expected, $this->invokePrivate($this->sharees, 'isRemoteSharingAllowed', [$itemType])); } - + public function testSearchNoItemType() { $this->expectException(\OCP\AppFramework\OCS\OCSBadRequestException::class); $this->expectExceptionMessage('Missing itemType'); -- cgit v1.2.3