From 0a9371f99f05786068d6f6a72b9a717ec24690a8 Mon Sep 17 00:00:00 2001 From: Côme Chilliet Date: Tue, 19 Sep 2023 16:06:40 +0200 Subject: Migrate applications away from deprecated ILogger MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Côme Chilliet --- .../settings/lib/Controller/WebAuthnController.php | 29 ++++++---------------- .../tests/Controller/UsersControllerTest.php | 3 --- 2 files changed, 8 insertions(+), 24 deletions(-) (limited to 'apps/settings') diff --git a/apps/settings/lib/Controller/WebAuthnController.php b/apps/settings/lib/Controller/WebAuthnController.php index 468685816f5..59c4d2146b1 100644 --- a/apps/settings/lib/Controller/WebAuthnController.php +++ b/apps/settings/lib/Controller/WebAuthnController.php @@ -33,37 +33,24 @@ use OCP\AppFramework\Controller; use OCP\AppFramework\Http; use OCP\AppFramework\Http\Attribute\IgnoreOpenAPI; use OCP\AppFramework\Http\JSONResponse; -use OCP\ILogger; use OCP\IRequest; use OCP\ISession; use OCP\IUserSession; +use Psr\Log\LoggerInterface; use Webauthn\PublicKeyCredentialCreationOptions; #[IgnoreOpenAPI] class WebAuthnController extends Controller { private const WEBAUTHN_REGISTRATION = 'webauthn_registration'; - /** @var Manager */ - private $manager; - - /** @var IUserSession */ - private $userSession; - /** - * @var ISession - */ - private $session; - /** - * @var ILogger - */ - private $logger; - - public function __construct(IRequest $request, ILogger $logger, Manager $webAuthnManager, IUserSession $userSession, ISession $session) { + public function __construct( + IRequest $request, + private LoggerInterface $logger, + private Manager $manager, + private IUserSession $userSession, + private ISession $session, + ) { parent::__construct(Application::APP_ID, $request); - - $this->manager = $webAuthnManager; - $this->userSession = $userSession; - $this->session = $session; - $this->logger = $logger; } /** diff --git a/apps/settings/tests/Controller/UsersControllerTest.php b/apps/settings/tests/Controller/UsersControllerTest.php index 6f0bf012889..6243b85fb2f 100644 --- a/apps/settings/tests/Controller/UsersControllerTest.php +++ b/apps/settings/tests/Controller/UsersControllerTest.php @@ -50,7 +50,6 @@ use OCP\IAvatarManager; use OCP\IConfig; use OCP\IGroupManager; use OCP\IL10N; -use OCP\ILogger; use OCP\IRequest; use OCP\IUser; use OCP\IUserManager; @@ -74,8 +73,6 @@ class UsersControllerTest extends \Test\TestCase { private $userSession; /** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */ private $config; - /** @var ILogger|\PHPUnit\Framework\MockObject\MockObject */ - private $logger; /** @var IMailer|\PHPUnit\Framework\MockObject\MockObject */ private $mailer; /** @var IFactory|\PHPUnit\Framework\MockObject\MockObject */ -- cgit v1.2.3