From 71781941984b75e12366fe87bb3d2f92f3dbf2ff Mon Sep 17 00:00:00 2001 From: Arthur Schiwon Date: Tue, 21 Sep 2021 11:47:00 +0200 Subject: fix caching of objectsid searches - store result when no name could be retrieved, too - cached value is not an array, was treated wrongly Signed-off-by: Arthur Schiwon --- apps/user_ldap/tests/Group_LDAPTest.php | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) (limited to 'apps/user_ldap/tests') diff --git a/apps/user_ldap/tests/Group_LDAPTest.php b/apps/user_ldap/tests/Group_LDAPTest.php index acb6ad3d710..cb637dcc108 100644 --- a/apps/user_ldap/tests/Group_LDAPTest.php +++ b/apps/user_ldap/tests/Group_LDAPTest.php @@ -320,6 +320,38 @@ class Group_LDAPTest extends TestCase { $this->assertSame(false, $gid); } + public function testPrimaryGroupID2NameSuccessCache() { + $access = $this->getAccessMock(); + $pluginManager = $this->getPluginManagerMock(); + + $this->enableGroups($access); + + $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar'; + $gid = '3117'; + $groupDN = 'cn=foo,dc=barfoo,dc=bar'; + + /** @var MockObject $connection */ + $connection = $access->connection; + $connection->expects($this->once()) + ->method('getFromCache') + ->with('primaryGroupIDtoName_' . $gid) + ->willReturn('MyGroup'); + + $access->expects($this->never()) + ->method('getSID'); + + $access->expects($this->never()) + ->method('searchGroups'); + + $access->expects($this->never()) + ->method('dn2groupname'); + + $groupBackend = new GroupLDAP($access, $pluginManager); + $group = $groupBackend->primaryGroupID2Name($gid, $userDN); + + $this->assertSame('MyGroup', $group); + } + public function testPrimaryGroupID2NameSuccess() { $access = $this->getAccessMock(); $pluginManager = $this->getPluginManagerMock(); -- cgit v1.2.3