From 89f4e16cdb90d4fe84597255a4c989adc2f8402a Mon Sep 17 00:00:00 2001 From: Arthur Schiwon Date: Mon, 11 Sep 2017 12:10:32 +0200 Subject: fix limit-flaw in search on paged results Signed-off-by: Arthur Schiwon --- .../tests/Integration/Lib/IntegrationTestPaging.php | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) (limited to 'apps/user_ldap/tests') diff --git a/apps/user_ldap/tests/Integration/Lib/IntegrationTestPaging.php b/apps/user_ldap/tests/Integration/Lib/IntegrationTestPaging.php index 44ee1c3bb5c..f9be6d6f675 100644 --- a/apps/user_ldap/tests/Integration/Lib/IntegrationTestPaging.php +++ b/apps/user_ldap/tests/Integration/Lib/IntegrationTestPaging.php @@ -47,6 +47,13 @@ class IntegrationTestPaging extends AbstractIntegrationTest { $this->backend = new User_LDAP($this->access, \OC::$server->getConfig(), \OC::$server->getNotificationManager()); } + public function initConnection() { + parent::initConnection(); + $this->connection->setConfiguration([ + 'ldapPagingSize' => 1 + ]); + } + /** * tests that paging works properly against a simple example (reading all * of few users in smallest steps) @@ -54,20 +61,18 @@ class IntegrationTestPaging extends AbstractIntegrationTest { * @return bool */ protected function case1() { - $limit = 1; $offset = 0; $filter = 'objectclass=inetorgperson'; $attributes = ['cn', 'dn']; $users = []; do { - $result = $this->access->searchUsers($filter, $attributes, $limit, $offset); + $result = $this->access->searchUsers($filter, $attributes, null, $offset); foreach($result as $user) { $users[] = $user['cn']; } - $offset += $limit; + $offset += count($users); } while ($this->access->hasMoreResults()); - if(count($users) === 2) { return true; } -- cgit v1.2.3