From c0200bc5c3268ae771a75c18f2f9694e79d14a67 Mon Sep 17 00:00:00 2001 From: Lukas Reschke Date: Tue, 8 Mar 2016 23:24:44 +0100 Subject: Use "hasKey" instead of checking the value If the check is negative it would depending on the used cache store the value as an empty string. When reading the value this check would thus return "false" even if a value exists. --- apps/files_sharing/lib/external/storage.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'apps') diff --git a/apps/files_sharing/lib/external/storage.php b/apps/files_sharing/lib/external/storage.php index 87f5a3598fb..80ab006f1ca 100644 --- a/apps/files_sharing/lib/external/storage.php +++ b/apps/files_sharing/lib/external/storage.php @@ -253,8 +253,8 @@ class Storage extends DAV implements ISharedStorage { */ private function testRemoteUrl($url) { $cache = $this->memcacheFactory->create('files_sharing_remote_url'); - if($result = $cache->get($url)) { - return (bool)$result; + if($cache->hasKey($url)) { + return (bool)$cache->get($url); } $result = file_get_contents($url); -- cgit v1.2.3