From 481f5bba81d2bf3c79c811cdefac8dd3e46d2012 Mon Sep 17 00:00:00 2001 From: fenn-cs Date: Fri, 15 Sep 2023 11:59:03 +0100 Subject: Correctly switch/revert from custom to bundled perms We have a set custom permissions checkbox, that when selected should set the quick permissions settings to custom as well as show the custom permission settings. When the checkbox is unchecked the quick permissions have to be reset to the default, `bundledPermissions.ALL` but also users can switch from custom permissions to `bundled` by just changing the radio select, hence we need a mechanism to set the permissions back to the correct fallback depending on where the user has toggled the the custom permission from. The mechanism is `revertSharingPermission` and this commit, makes sure revert values are correctly set upon toggle. Resolves : https://github.com/nextcloud/server/issues/40431 Signed-off-by: fenn-cs Signed-off-by: nextcloud-command --- apps/files_sharing/src/views/SharingDetailsTab.vue | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'apps') diff --git a/apps/files_sharing/src/views/SharingDetailsTab.vue b/apps/files_sharing/src/views/SharingDetailsTab.vue index e62a1ab94d7..b25ca81373c 100644 --- a/apps/files_sharing/src/views/SharingDetailsTab.vue +++ b/apps/files_sharing/src/views/SharingDetailsTab.vue @@ -255,7 +255,7 @@ export default { return { writeNoteToRecipientIsChecked: false, sharingPermission: BUNDLED_PERMISSIONS.ALL.toString(), - revertSharingPermission: null, + revertSharingPermission: BUNDLED_PERMISSIONS.ALL.toString(), setCustomPermissions: false, passwordError: false, advancedSectionAccordionExpanded: false, @@ -667,8 +667,10 @@ export default { } this.toggleCustomPermissions() }, - toggleCustomPermissions() { - this.setCustomPermissions = this.sharingPermission === 'custom' + toggleCustomPermissions(selectedPermission) { + const isCustomPermissions = this.sharingPermission === 'custom' + this.revertSharingPermission = !isCustomPermissions ? selectedPermission : 'custom' + this.setCustomPermissions = isCustomPermissions }, initializeAttributes() { -- cgit v1.2.3