From 691f570237e26398aa22f40c0efca23141d5583e Mon Sep 17 00:00:00 2001 From: Ferdinand Thiessen Date: Tue, 25 Jun 2024 00:00:31 +0200 Subject: chore: Enable ESLint for apps and fix all errors Nevertheless this causes a huge amount of new warnings. Previously the shell script for directories to lint was wrong it was generating all app names to lint, but was missing the `apps/` prefix. Causing only `core` to be linted. Co-authored-by: Grigorii K. Shartsev Signed-off-by: Ferdinand Thiessen --- apps/comments/src/services/DavClient.js | 12 +++--- apps/comments/src/services/GetComments.ts | 2 +- apps/comments/src/utils/cancelableRequest.js | 2 +- apps/dav/src/components/AbsenceForm.vue | 35 ++++++++-------- apps/dav/src/dav/client.js | 2 +- apps/dav/src/service/PreferenceService.js | 4 +- apps/dav/src/settings.js | 4 +- apps/dav/src/views/CalDavSettings.spec.js | 12 +++--- apps/dav/src/views/CalDavSettings.vue | 4 +- .../src/components/AdminSettings.vue | 7 ++-- .../src/components/PersonalSettings.vue | 4 +- apps/federatedfilesharing/src/external.js | 2 +- apps/files/src/actions/deleteAction.ts | 2 +- apps/files/src/actions/sidebarAction.ts | 2 +- apps/files/src/components/FileEntryMixin.ts | 4 +- apps/files/src/components/NavigationQuota.vue | 10 ++--- .../src/components/TransferOwnershipDialogue.vue | 6 +-- apps/files/src/components/VirtualList.vue | 10 +++-- apps/files/src/composables/useNavigation.spec.ts | 16 ++++---- apps/files/src/init.ts | 1 - apps/files/src/main.ts | 6 +-- apps/files/src/plugins/search/folderSearch.ts | 4 +- apps/files/src/services/LivePhotos.ts | 3 ++ apps/files/src/services/PreviewService.ts | 1 + apps/files/src/store/dragging.ts | 1 + apps/files/src/store/files.ts | 4 ++ apps/files/src/store/keyboard.ts | 1 + apps/files/src/store/selection.ts | 2 + apps/files/src/store/userconfig.ts | 4 ++ apps/files/src/store/viewConfig.ts | 9 +++++ .../src/actions/inlineStorageCheckAction.ts | 3 +- apps/files_external/tests/appSpec.js | 2 +- .../src/actions/setReminderSuggestionActions.ts | 8 ++-- apps/files_reminders/src/shared/types.ts | 2 +- apps/files_sharing/src/components/SharingInput.vue | 3 +- apps/files_sharing/src/mixins/ShareDetails.js | 1 - apps/files_sharing/src/services/SharingService.ts | 12 ++++-- apps/files_trashbin/src/services/client.ts | 12 +++--- apps/files_versions/src/utils/davClient.js | 14 +++---- apps/oauth2/src/App.vue | 2 +- apps/oauth2/src/components/OAuthItem.vue | 6 +-- .../src/components/AdminSettingsSharingForm.vue | 20 ++++++---- .../src/components/BasicSettings/BackgroundJob.vue | 10 +++-- .../DeclarativeSettings/DeclarativeSection.vue | 46 +++++++++------------- apps/settings/src/components/Encryption.vue | 18 ++++----- .../components/PersonalInfo/BirthdaySection.vue | 16 ++++---- apps/settings/src/components/Users/UserRow.vue | 2 +- .../settings/src/components/WebAuthn/AddDevice.vue | 2 + apps/settings/src/components/WebAuthn/Section.vue | 3 +- .../src/main-declarative-settings-forms.ts | 41 +++++++++++-------- .../src/service/PersonalInfo/EmailService.js | 5 ++- .../service/PersonalInfo/PersonalInfoService.js | 5 ++- apps/settings/src/store/apps.js | 2 +- apps/settings/src/store/authtoken.ts | 2 + apps/settings/src/store/users.js | 1 + apps/settings/src/utils/userUtils.ts | 4 +- apps/sharebymail/src/components/AdminSettings.vue | 7 ++-- apps/systemtags/src/services/api.ts | 1 + apps/systemtags/src/services/davClient.ts | 12 +++--- apps/systemtags/src/services/files.ts | 2 + apps/systemtags/src/utils.ts | 9 +++-- apps/theming/src/components/BackgroundSettings.vue | 2 +- apps/theming/src/components/ItemPreview.vue | 4 +- .../theming/src/components/admin/CheckboxField.vue | 8 ++-- .../src/components/admin/FileInputField.vue | 4 +- .../src/views/PersonalSettings.vue | 5 ++- apps/workflowengine/src/components/Rule.vue | 2 +- apps/workflowengine/src/store.js | 5 ++- 68 files changed, 266 insertions(+), 213 deletions(-) (limited to 'apps') diff --git a/apps/comments/src/services/DavClient.js b/apps/comments/src/services/DavClient.js index 6202294b52f..3e9a529283f 100644 --- a/apps/comments/src/services/DavClient.js +++ b/apps/comments/src/services/DavClient.js @@ -12,12 +12,12 @@ const client = createClient(getRootPath()) // set CSRF token header const setHeaders = (token) => { - client.setHeaders({ - // Add this so the server knows it is an request from the browser - 'X-Requested-With': 'XMLHttpRequest', - // Inject user auth - requesttoken: token ?? '', - }) + client.setHeaders({ + // Add this so the server knows it is an request from the browser + 'X-Requested-With': 'XMLHttpRequest', + // Inject user auth + requesttoken: token ?? '', + }) } // refresh headers when request token changes diff --git a/apps/comments/src/services/GetComments.ts b/apps/comments/src/services/GetComments.ts index 1e24c8ede8e..c42aa21d6cb 100644 --- a/apps/comments/src/services/GetComments.ts +++ b/apps/comments/src/services/GetComments.ts @@ -60,7 +60,7 @@ const getDirectoryFiles = function( // Map all items to a consistent output structure (results) return responseItems.map(item => { // Each item should contain a stat object - const props = item.propstat!.prop!; + const props = item.propstat!.prop! return prepareFileFromProps(props, props.id!.toString(), isDetailed) }) diff --git a/apps/comments/src/utils/cancelableRequest.js b/apps/comments/src/utils/cancelableRequest.js index 47baa505083..c2d380c80f9 100644 --- a/apps/comments/src/utils/cancelableRequest.js +++ b/apps/comments/src/utils/cancelableRequest.js @@ -22,7 +22,7 @@ const cancelableRequest = function(request) { const fetch = async function(url, options) { const response = await request( url, - Object.assign({ signal }, options) + Object.assign({ signal }, options), ) return response } diff --git a/apps/dav/src/components/AbsenceForm.vue b/apps/dav/src/components/AbsenceForm.vue index 33f1483a7fb..cb3fabe49df 100644 --- a/apps/dav/src/components/AbsenceForm.vue +++ b/apps/dav/src/components/AbsenceForm.vue @@ -26,8 +26,7 @@ :clear-search-on-blur="() => false" :user-select="true" :options="options" - @search="asyncFind" - > + @search="asyncFind"> @@ -51,21 +50,21 @@ diff --git a/apps/settings/src/components/BasicSettings/BackgroundJob.vue b/apps/settings/src/components/BasicSettings/BackgroundJob.vue index e699323be80..835f65a2477 100644 --- a/apps/settings/src/components/BasicSettings/BackgroundJob.vue +++ b/apps/settings/src/components/BasicSettings/BackgroundJob.vue @@ -63,13 +63,15 @@