From 2317d7bb497cce3e5731dd43e2e69b9d3e780bb0 Mon Sep 17 00:00:00 2001 From: Christoph Wurst Date: Mon, 24 Apr 2017 10:39:37 +0200 Subject: Fix sinon.stub deprecation warnings Calls to `sinon.stub(obj, 'meth', fn)` are deprecated and therefore replaced by `sinon.stub(obj, 'meth).callsFake(fn)` as instructed by the deprecation warning. This makes the js unit testing output readable again. Signed-off-by: Christoph Wurst --- apps/federatedfilesharing/tests/js/externalSpec.js | 6 ++++-- apps/files/tests/js/filelistSpec.js | 2 +- apps/files_external/tests/js/settingsSpec.js | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) (limited to 'apps') diff --git a/apps/federatedfilesharing/tests/js/externalSpec.js b/apps/federatedfilesharing/tests/js/externalSpec.js index 362df49252b..596c0ae60ac 100644 --- a/apps/federatedfilesharing/tests/js/externalSpec.js +++ b/apps/federatedfilesharing/tests/js/externalSpec.js @@ -8,6 +8,8 @@ * */ +/* global sinon */ + describe('OCA.Sharing external tests', function() { var plugin; var urlQueryStub; @@ -24,8 +26,8 @@ describe('OCA.Sharing external tests', function() { plugin = OCA.Sharing.ExternalShareDialogPlugin; urlQueryStub = sinon.stub(OC.Util.History, 'parseUrlQuery'); - confirmDialogStub = sinon.stub(OC.dialogs, 'confirm', dummyShowDialog); - promptDialogStub = sinon.stub(OC.dialogs, 'prompt', dummyShowDialog); + confirmDialogStub = sinon.stub(OC.dialogs, 'confirm').callsFake(dummyShowDialog); + promptDialogStub = sinon.stub(OC.dialogs, 'prompt').callsFake(dummyShowDialog); plugin.filesApp = { fileList: { diff --git a/apps/files/tests/js/filelistSpec.js b/apps/files/tests/js/filelistSpec.js index 865aa35ac6a..ee73914f166 100644 --- a/apps/files/tests/js/filelistSpec.js +++ b/apps/files/tests/js/filelistSpec.js @@ -2273,7 +2273,7 @@ describe('OCA.Files.FileList tests', function() { var actionStub = sinon.stub(); var readyHandler = sinon.stub(); var clock = sinon.useFakeTimers(); - var debounceStub = sinon.stub(_, 'debounce', function(callback) { + var debounceStub = sinon.stub(_, 'debounce').callsFake(function(callback) { return function() { // defer instead of debounce, to make it work with clock _.defer(callback); diff --git a/apps/files_external/tests/js/settingsSpec.js b/apps/files_external/tests/js/settingsSpec.js index 2639f634b26..d6b96a47189 100644 --- a/apps/files_external/tests/js/settingsSpec.js +++ b/apps/files_external/tests/js/settingsSpec.js @@ -15,7 +15,7 @@ describe('OCA.External.Settings tests', function() { beforeEach(function() { clock = sinon.useFakeTimers(); - select2Stub = sinon.stub($.fn, 'select2', function(args) { + select2Stub = sinon.stub($.fn, 'select2').callsFake(function(args) { if (args === 'val') { return select2ApplicableUsers; } -- cgit v1.2.3