From 11cacf63f8249561b856d6283b6b7a7fcfb3bdad Mon Sep 17 00:00:00 2001 From: Daniel Kesselberg Date: Tue, 8 Jun 2021 16:30:44 +0200 Subject: Fix #26085 addOrderBy expects a order expression. For the migration scenario we have column objects. Column objects are not supported by quoteColumnName yet. A column object as order expression is most likely an edgy thing when migration database information. Signed-off-by: Daniel Kesselberg --- core/Command/Db/ConvertType.php | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'core/Command') diff --git a/core/Command/Db/ConvertType.php b/core/Command/Db/ConvertType.php index e4252264dbb..f05bcdef28e 100644 --- a/core/Command/Db/ConvertType.php +++ b/core/Command/Db/ConvertType.php @@ -337,14 +337,11 @@ class ConvertType extends Command implements CompletionAwareInterface { try { $orderColumns = $table->getPrimaryKeyColumns(); } catch (Exception $e) { - $orderColumns = []; - foreach ($table->getColumns() as $column) { - $orderColumns[] = $column->getName(); - } + $orderColumns = $table->getColumns(); } foreach ($orderColumns as $column) { - $query->addOrderBy($column); + $query->addOrderBy($column->getName()); } $insertQuery = $toDB->getQueryBuilder(); -- cgit v1.2.3