From 3ef04909b716ba1495b6ba1d4797f9f467941065 Mon Sep 17 00:00:00 2001 From: Nils Wenninghoff Date: Sat, 12 Oct 2024 00:03:32 +0200 Subject: fix(ConvertType): Read dbtype in createConnectionParams and remove safeguard Signed-off-by: Nils Wenninghoff --- core/Command/Db/ConvertType.php | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'core/Command') diff --git a/core/Command/Db/ConvertType.php b/core/Command/Db/ConvertType.php index 4d95ee50c4e..fd0db129b7f 100644 --- a/core/Command/Db/ConvertType.php +++ b/core/Command/Db/ConvertType.php @@ -177,13 +177,6 @@ class ConvertType extends Command implements CompletionAwareInterface { } protected function execute(InputInterface $input, OutputInterface $output): int { - // WARNING: - // Leave in place until #45257 is addressed to prevent data loss (hopefully in time for the next maintenance release) - // - throw new \InvalidArgumentException( - 'This command is temporarily disabled (until the next maintenance release).' - ); - $this->validateInput($input, $output); $this->readPassword($input, $output); @@ -251,7 +244,7 @@ class ConvertType extends Command implements CompletionAwareInterface { protected function getToDBConnection(InputInterface $input, OutputInterface $output) { $type = $input->getArgument('type'); - $connectionParams = $this->connectionFactory->createConnectionParams(); + $connectionParams = $this->connectionFactory->createConnectionParams(type: $type); $connectionParams = array_merge($connectionParams, [ 'host' => $input->getArgument('hostname'), 'user' => $input->getArgument('username'), -- cgit v1.2.3