From 883a71ce8e00d317e1827deacf46ee0c37934485 Mon Sep 17 00:00:00 2001 From: Daniel Calviño Sánchez Date: Thu, 7 Nov 2019 21:30:56 +0100 Subject: Split the menu entry for external shares in two MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The external shares entry showed a "button" that, when pressed, replaced the button with the input to set the remote share address. The "button" was actually a label for the input, so when the label was focused it transferred the focus to the input and thus pressing enter or space did not show the input. Moreover, inputs inside links are not valid HTML, and once shown there was no way to hide the input again. Due to all this, and for consistency with the direct link input, the external share input was moved to a different menu item that is shown and hidden when the button, which nows is also a real button, is clicked. Signed-off-by: Daniel Calviño Sánchez --- core/js/public/publicpage.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'core/js') diff --git a/core/js/public/publicpage.js b/core/js/public/publicpage.js index e71bdff12ae..4fb9c67bfee 100644 --- a/core/js/public/publicpage.js +++ b/core/js/public/publicpage.js @@ -26,9 +26,8 @@ $(document).ready(function () { $(this).next('.popovermenu').toggleClass('open'); }); - $('#save-external-share').find('label').click(function () { - $(this).toggleClass('hidden'); - $('.save-form').toggleClass('hidden') + $('#save-external-share').click(function () { + $('#external-share-menu-item').toggleClass('hidden') $('#remote_address').focus(); }); -- cgit v1.2.3