From e025cf067f63b69c0613106a6a1aba7c4f963641 Mon Sep 17 00:00:00 2001
From: Daniel Kesselberg <mail@danielkesselberg.de>
Date: Tue, 14 Mar 2023 10:25:16 +0100
Subject: fix: wrong redirect when skipping recommended apps

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
---
 core/src/components/setup/RecommendedApps.vue | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

(limited to 'core/src')

diff --git a/core/src/components/setup/RecommendedApps.vue b/core/src/components/setup/RecommendedApps.vue
index 984a6800475..472c011c762 100644
--- a/core/src/components/setup/RecommendedApps.vue
+++ b/core/src/components/setup/RecommendedApps.vue
@@ -59,8 +59,7 @@
 			<NcButton v-if="showInstallButton"
 				type="tertiary"
 				role="link"
-				href="defaultPageUrl"
-				@click="goTo(defaultPageUrl)">
+				:href="defaultPageUrl">
 				{{ t('core', 'Skip') }}
 			</NcButton>
 
@@ -115,7 +114,6 @@ const recommended = {
 	},
 }
 const recommendedIds = Object.keys(recommended)
-const defaultPageUrl = loadState('core', 'defaultPageUrl')
 
 export default {
 	name: 'RecommendedApps',
@@ -129,7 +127,7 @@ export default {
 			loadingApps: true,
 			loadingAppsError: false,
 			apps: [],
-			defaultPageUrl,
+			defaultPageUrl: loadState('core', 'defaultPageUrl')
 		}
 	},
 	computed: {
@@ -180,7 +178,7 @@ export default {
 				.then(() => {
 					logger.info('all recommended apps installed, redirecting …')
 
-					window.location = defaultPageUrl
+					window.location = this.defaultPageUrl
 				})
 				.catch(error => logger.error('could not install recommended apps', { error }))
 		},
@@ -210,9 +208,6 @@ export default {
 			}
 			return !!recommended[appId].hidden
 		},
-		goTo(href) {
-			window.location.href = href
-		},
 	},
 }
 </script>
-- 
cgit v1.2.3