From 006e150c879312264db10009792c7035be9562dc Mon Sep 17 00:00:00 2001 From: Timo Förster Date: Fri, 27 Jul 2018 11:20:47 +0200 Subject: Change check if secure randomness is possible. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Timo Förster --- core/js/setupchecks.js | 6 +++--- core/js/tests/specs/setupchecksSpec.js | 30 +++++++++++++++--------------- 2 files changed, 18 insertions(+), 18 deletions(-) (limited to 'core') diff --git a/core/js/setupchecks.js b/core/js/setupchecks.js index 628606a9e5b..62f0fb10c10 100644 --- a/core/js/setupchecks.js +++ b/core/js/setupchecks.js @@ -183,10 +183,10 @@ type: OC.SetupChecks.MESSAGE_TYPE_INFO }); } - if(!data.isUrandomAvailable) { + if(!data.isRandomnessSecure) { messages.push({ - msg: t('core', '/dev/urandom is not readable by PHP which is highly discouraged for security reasons. Further information can be found in the documentation.', {docLink: data.securityDocs}), - type: OC.SetupChecks.MESSAGE_TYPE_WARNING + msg: t('core', 'No suitable source for randomness found by PHP which is highly discouraged for security reasons. Further information can be found in the documentation.', {docLink: data.securityDocs}), + type: OC.SetupChecks.MESSAGE_TYPE_ERROR }); } if(data.isUsedTlsLibOutdated) { diff --git a/core/js/tests/specs/setupchecksSpec.js b/core/js/tests/specs/setupchecksSpec.js index 4c0545b7b4f..41bed276b6f 100644 --- a/core/js/tests/specs/setupchecksSpec.js +++ b/core/js/tests/specs/setupchecksSpec.js @@ -155,7 +155,7 @@ describe('OC.SetupChecks tests', function() { hasWorkingFileLocking: true, hasValidTransactionIsolationLevel: true, suggestedOverwriteCliURL: '', - isUrandomAvailable: true, + isRandomnessSecure: true, serverHasInternetConnection: false, memcacheDocs: 'https://docs.nextcloud.com/server/go.php?to=admin-performance', forwardedForHeadersWorking: true, @@ -204,7 +204,7 @@ describe('OC.SetupChecks tests', function() { hasWorkingFileLocking: true, hasValidTransactionIsolationLevel: true, suggestedOverwriteCliURL: '', - isUrandomAvailable: true, + isRandomnessSecure: true, serverHasInternetConnection: false, memcacheDocs: 'https://docs.nextcloud.com/server/go.php?to=admin-performance', forwardedForHeadersWorking: true, @@ -254,7 +254,7 @@ describe('OC.SetupChecks tests', function() { hasWorkingFileLocking: true, hasValidTransactionIsolationLevel: true, suggestedOverwriteCliURL: '', - isUrandomAvailable: true, + isRandomnessSecure: true, serverHasInternetConnection: false, isMemcacheConfigured: true, forwardedForHeadersWorking: true, @@ -301,7 +301,7 @@ describe('OC.SetupChecks tests', function() { hasWorkingFileLocking: true, hasValidTransactionIsolationLevel: true, suggestedOverwriteCliURL: '', - isUrandomAvailable: false, + isRandomnessSecure: false, securityDocs: 'https://docs.owncloud.org/myDocs.html', serverHasInternetConnection: true, isMemcacheConfigured: true, @@ -325,8 +325,8 @@ describe('OC.SetupChecks tests', function() { async.done(function( data, s, x ){ expect(data).toEqual([{ - msg: '/dev/urandom is not readable by PHP which is highly discouraged for security reasons. Further information can be found in the documentation.', - type: OC.SetupChecks.MESSAGE_TYPE_WARNING + msg: 'No suitable source for randomness found by PHP which is highly discouraged for security reasons. Further information can be found in the documentation.', + type: OC.SetupChecks.MESSAGE_TYPE_ERROR }]); done(); }); @@ -347,7 +347,7 @@ describe('OC.SetupChecks tests', function() { hasWorkingFileLocking: true, hasValidTransactionIsolationLevel: true, suggestedOverwriteCliURL: '', - isUrandomAvailable: true, + isRandomnessSecure: true, securityDocs: 'https://docs.owncloud.org/myDocs.html', serverHasInternetConnection: true, isMemcacheConfigured: true, @@ -393,7 +393,7 @@ describe('OC.SetupChecks tests', function() { hasWorkingFileLocking: true, hasValidTransactionIsolationLevel: true, suggestedOverwriteCliURL: '', - isUrandomAvailable: true, + isRandomnessSecure: true, securityDocs: 'https://docs.owncloud.org/myDocs.html', serverHasInternetConnection: true, isMemcacheConfigured: true, @@ -441,7 +441,7 @@ describe('OC.SetupChecks tests', function() { hasWorkingFileLocking: true, hasValidTransactionIsolationLevel: true, suggestedOverwriteCliURL: '', - isUrandomAvailable: true, + isRandomnessSecure: true, serverHasInternetConnection: true, isMemcacheConfigured: true, forwardedForHeadersWorking: false, @@ -487,7 +487,7 @@ describe('OC.SetupChecks tests', function() { hasWorkingFileLocking: true, hasValidTransactionIsolationLevel: true, suggestedOverwriteCliURL: '', - isUrandomAvailable: true, + isRandomnessSecure: true, serverHasInternetConnection: true, isMemcacheConfigured: true, forwardedForHeadersWorking: true, @@ -533,7 +533,7 @@ describe('OC.SetupChecks tests', function() { hasWorkingFileLocking: true, hasValidTransactionIsolationLevel: true, suggestedOverwriteCliURL: '', - isUrandomAvailable: true, + isRandomnessSecure: true, serverHasInternetConnection: true, isMemcacheConfigured: true, forwardedForHeadersWorking: true, @@ -599,7 +599,7 @@ describe('OC.SetupChecks tests', function() { hasWorkingFileLocking: true, hasValidTransactionIsolationLevel: true, suggestedOverwriteCliURL: '', - isUrandomAvailable: true, + isRandomnessSecure: true, securityDocs: 'https://docs.owncloud.org/myDocs.html', serverHasInternetConnection: true, isMemcacheConfigured: true, @@ -646,7 +646,7 @@ describe('OC.SetupChecks tests', function() { hasWorkingFileLocking: true, hasValidTransactionIsolationLevel: true, suggestedOverwriteCliURL: '', - isUrandomAvailable: true, + isRandomnessSecure: true, securityDocs: 'https://docs.owncloud.org/myDocs.html', serverHasInternetConnection: true, isMemcacheConfigured: true, @@ -693,7 +693,7 @@ describe('OC.SetupChecks tests', function() { hasWorkingFileLocking: true, hasValidTransactionIsolationLevel: true, suggestedOverwriteCliURL: '', - isUrandomAvailable: true, + isRandomnessSecure: true, securityDocs: 'https://docs.owncloud.org/myDocs.html', serverHasInternetConnection: true, isMemcacheConfigured: true, @@ -740,7 +740,7 @@ describe('OC.SetupChecks tests', function() { hasWorkingFileLocking: true, hasValidTransactionIsolationLevel: true, suggestedOverwriteCliURL: '', - isUrandomAvailable: true, + isRandomnessSecure: true, securityDocs: 'https://docs.owncloud.org/myDocs.html', serverHasInternetConnection: true, isMemcacheConfigured: true, -- cgit v1.2.3