From 4e95031ec4e74bb99dc2dc819ddb77893564e01c Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Mon, 15 Jun 2015 12:51:22 +0200 Subject: Allow app:check-code to check for deprecated methods --- core/command/app/checkcode.php | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) (limited to 'core') diff --git a/core/command/app/checkcode.php b/core/command/app/checkcode.php index ecec51e5768..8bd079eaad1 100644 --- a/core/command/app/checkcode.php +++ b/core/command/app/checkcode.php @@ -23,9 +23,12 @@ namespace OC\Core\Command\App; +use OC\App\CodeChecker; +use OC\App\DeprecationCodeChecker; use Symfony\Component\Console\Command\Command; use Symfony\Component\Console\Input\InputArgument; use Symfony\Component\Console\Input\InputInterface; +use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; class CheckCode extends Command { @@ -37,12 +40,22 @@ class CheckCode extends Command { 'app-id', InputArgument::REQUIRED, 'check the specified app' + ) + ->addOption( + 'deprecated', + 'd', + InputOption::VALUE_NONE, + 'check the specified app' ); } protected function execute(InputInterface $input, OutputInterface $output) { $appId = $input->getArgument('app-id'); - $codeChecker = new \OC\App\CodeChecker(); + if ($input->getOption('deprecated')) { + $codeChecker = new DeprecationCodeChecker(); + } else { + $codeChecker = new CodeChecker(); + } $codeChecker->listen('CodeChecker', 'analyseFileBegin', function($params) use ($output) { if(OutputInterface::VERBOSITY_VERBOSE <= $output->getVerbosity()) { $output->writeln("Analysing {$params}"); @@ -72,6 +85,8 @@ class CheckCode extends Command { $errors = $codeChecker->analyse($appId); if (empty($errors)) { $output->writeln('App is compliant - awesome job!'); + } elseif ($input->getOption('deprecated')) { + $output->writeln('App uses deprecated functionality'); } else { $output->writeln('App is not compliant'); return 1; -- cgit v1.2.3