From 2317d7bb497cce3e5731dd43e2e69b9d3e780bb0 Mon Sep 17 00:00:00 2001 From: Christoph Wurst Date: Mon, 24 Apr 2017 10:39:37 +0200 Subject: Fix sinon.stub deprecation warnings Calls to `sinon.stub(obj, 'meth', fn)` are deprecated and therefore replaced by `sinon.stub(obj, 'meth).callsFake(fn)` as instructed by the deprecation warning. This makes the js unit testing output readable again. Signed-off-by: Christoph Wurst --- core/js/tests/specs/jquery.avatarSpec.js | 2 +- core/js/tests/specs/sharedialogviewSpec.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'core') diff --git a/core/js/tests/specs/jquery.avatarSpec.js b/core/js/tests/specs/jquery.avatarSpec.js index 9bb10c41be7..dab78500d0b 100644 --- a/core/js/tests/specs/jquery.avatarSpec.js +++ b/core/js/tests/specs/jquery.avatarSpec.js @@ -186,7 +186,7 @@ describe('jquery.avatar tests', function() { }); it('with ie8 fix', function() { - sinon.stub(Math, 'random', function() { + sinon.stub(Math, 'random').callsFake(function() { return 0.5; }); diff --git a/core/js/tests/specs/sharedialogviewSpec.js b/core/js/tests/specs/sharedialogviewSpec.js index 307adea85ff..95349bc4875 100644 --- a/core/js/tests/specs/sharedialogviewSpec.js +++ b/core/js/tests/specs/sharedialogviewSpec.js @@ -19,7 +19,7 @@ * */ -/* global oc_appconfig */ +/* global oc_appconfig, sinon */ describe('OC.Share.ShareDialogView', function() { var $container; var oldAppConfig; @@ -90,7 +90,7 @@ describe('OC.Share.ShareDialogView', function() { linkShare: {isLinkShare: false} }); - autocompleteStub = sinon.stub($.fn, 'autocomplete', function() { + autocompleteStub = sinon.stub($.fn, 'autocomplete').callsFake(function() { // dummy container with the expected attributes if (!$(this).length) { // simulate the real autocomplete that returns -- cgit v1.2.3