From 06d076410a05265579e60a5393ec2e6c11f83c17 Mon Sep 17 00:00:00 2001 From: Johannes Merkel Date: Tue, 30 Jan 2024 15:07:17 +0100 Subject: feat(occ): add possibility to edit indices Signed-off-by: Johannes Merkel --- core/Command/Db/AddMissingIndices.php | 56 +++++++++++++++++++++++++++++++---- 1 file changed, 51 insertions(+), 5 deletions(-) (limited to 'core') diff --git a/core/Command/Db/AddMissingIndices.php b/core/Command/Db/AddMissingIndices.php index bd47fea20fe..1e10b6152ce 100644 --- a/core/Command/Db/AddMissingIndices.php +++ b/core/Command/Db/AddMissingIndices.php @@ -73,7 +73,9 @@ class AddMissingIndices extends Command { $this->dispatcher->dispatchTyped($event); $missingIndices = $event->getMissingIndices(); - if ($missingIndices !== []) { + $toReplaceIndices = $event->getIndicesToReplace(); + + if ($missingIndices !== [] || $toReplaceIndices !== []) { $schema = new SchemaWrapper($this->connection); foreach ($missingIndices as $missingIndex) { @@ -97,15 +99,59 @@ class AddMissingIndices extends Command { $table->addIndex($missingIndex['columns'], $missingIndex['indexName'], [], $missingIndex['options']); } - - $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun); - if ($dryRun && $sqlQueries !== null) { - $output->writeln($sqlQueries); + if (!$dryRun) { + $this->connection->migrateToSchema($schema->getWrappedSchema()); } $output->writeln('' . $table->getName() . ' table updated successfully.'); } } } + + foreach ($toReplaceIndices as $toReplaceIndex) { + if ($schema->hasTable($toReplaceIndex['tableName'])) { + $table = $schema->getTable($toReplaceIndex['tableName']); + + $allOldIndicesExists = true; + foreach ($toReplaceIndex['oldIndexNames'] as $oldIndexName) { + if (!$table->hasIndex($oldIndexName)) { + $allOldIndicesExists = false; + } + } + + if (!$allOldIndicesExists) { + continue; + } + + $output->writeln('Adding additional ' . $toReplaceIndex['newIndexName'] . ' index to the ' . $table->getName() . ' table, this can take some time...'); + + if ($toReplaceIndex['uniqueIndex']) { + $table->addUniqueIndex($toReplaceIndex['columns'], $toReplaceIndex['newIndexName'], $toReplaceIndex['options']); + } else { + $table->addIndex($toReplaceIndex['columns'], $toReplaceIndex['newIndexName'], [], $toReplaceIndex['options']); + } + + if (!$dryRun) { + $this->connection->migrateToSchema($schema->getWrappedSchema()); + } + + foreach ($toReplaceIndex['oldIndexNames'] as $oldIndexName) { + $output->writeln('Removing ' . $oldIndexName . ' index from the ' . $table->getName() . ' table'); + $table->dropIndex($oldIndexName); + } + + if (!$dryRun) { + $this->connection->migrateToSchema($schema->getWrappedSchema()); + } + $output->writeln('' . $table->getName() . ' table updated successfully.'); + } + } + + if ($dryRun) { + $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun); + if ($sqlQueries !== null) { + $output->writeln($sqlQueries); + } + } } return 0; -- cgit v1.2.3