From 344c8a409c733068e7d22b5b182f30f5defda624 Mon Sep 17 00:00:00 2001
From: Ferdinand Thiessen <opensource@fthiessen.de>
Date: Thu, 16 Jan 2025 23:25:59 +0100
Subject: fix(files): Ensure favorites set in sidebar work

When marking a file as favorite from within the sidebar make sure it
really works, this fixes two issues:
1. The source needs to be the plain source not URL encoded, as otherwise
   the source of the node would be encoded twice (and show with encoding
   in the navigation)
2. The store should also listen for the update events as the sidebar has
   no access to the real node to update it, instead the store should -
   as long as we only have the legacy sidebar - update the node when
   added or removed as favorite.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
---
 cypress/e2e/files/favorites.cy.ts | 137 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 137 insertions(+)
 create mode 100644 cypress/e2e/files/favorites.cy.ts

(limited to 'cypress')

diff --git a/cypress/e2e/files/favorites.cy.ts b/cypress/e2e/files/favorites.cy.ts
new file mode 100644
index 00000000000..d873e6963e6
--- /dev/null
+++ b/cypress/e2e/files/favorites.cy.ts
@@ -0,0 +1,137 @@
+/*!
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+import type { User } from '@nextcloud/cypress'
+import { getActionButtonForFile, getRowForFile, triggerActionForFile } from './FilesUtils'
+
+describe('files: Favorites', { testIsolation: true }, () => {
+	let user: User
+
+	beforeEach(() => {
+		cy.createRandomUser().then(($user) => {
+			user = $user
+			cy.uploadContent(user, new Blob([]), 'text/plain', '/file.txt')
+			cy.mkdir(user, '/new folder')
+			cy.login(user)
+			cy.visit('/apps/files')
+		})
+	})
+
+	it('Mark file as favorite', () => {
+		// See file exists
+		getRowForFile('file.txt')
+			.should('exist')
+
+		cy.intercept('POST', '**/apps/files/api/v1/files/file.txt').as('addToFavorites')
+		// Click actions
+		getActionButtonForFile('file.txt').click({ force: true })
+		// See action is called 'Add to favorites'
+		cy.get('[data-cy-files-list-row-action="favorite"] > button').last()
+			.should('exist')
+			.and('have.text', 'Add to favorites')
+			.click({ force: true })
+		cy.wait('@addToFavorites')
+		// See favorites star
+		getRowForFile('file.txt')
+			.findByRole('img', { name: 'Favorite' })
+			.should('exist')
+	})
+
+	it('Un-mark file as favorite', () => {
+		// See file exists
+		getRowForFile('file.txt')
+			.should('exist')
+
+		cy.intercept('POST', '**/apps/files/api/v1/files/file.txt').as('addToFavorites')
+		// toggle favorite
+		triggerActionForFile('file.txt', 'favorite')
+		cy.wait('@addToFavorites')
+
+		// See favorites star
+		getRowForFile('file.txt')
+			.findByRole('img', { name: 'Favorite' })
+			.should('be.visible')
+
+		// Remove favorite
+		// click action button
+		getActionButtonForFile('file.txt').click({ force: true })
+		// See action is called 'Remove from favorites'
+		cy.get('[data-cy-files-list-row-action="favorite"] > button').last()
+			.should('exist')
+			.and('have.text', 'Remove from favorites')
+			.click({ force: true })
+		cy.wait('@addToFavorites')
+		// See no favorites star anymore
+		getRowForFile('file.txt')
+			.findByRole('img', { name: 'Favorite' })
+			.should('not.exist')
+	})
+
+	it('See favorite folders in navigation', () => {
+		cy.intercept('POST', '**/apps/files/api/v1/files/new%20folder').as('addToFavorites')
+
+		// see navigation has no entry
+		cy.get('[data-cy-files-navigation-item="favorites"]')
+			.should('be.visible')
+			.contains('new folder')
+			.should('not.exist')
+
+		// toggle favorite
+		triggerActionForFile('new folder', 'favorite')
+		cy.wait('@addToFavorites')
+
+		// See in navigation
+		cy.get('[data-cy-files-navigation-item="favorites"]')
+			.should('be.visible')
+			.contains('new folder')
+			.should('exist')
+
+		// toggle favorite
+		triggerActionForFile('new folder', 'favorite')
+		cy.wait('@addToFavorites')
+
+		// See no longer in navigation
+		cy.get('[data-cy-files-navigation-item="favorites"]')
+			.should('be.visible')
+			.contains('new folder')
+			.should('not.exist')
+	})
+
+	it('Mark file as favorite using the sidebar', () => {
+		// See file exists
+		getRowForFile('new folder')
+			.should('exist')
+		// see navigation has no entry
+		cy.get('[data-cy-files-navigation-item="favorites"]')
+			.should('be.visible')
+			.contains('new folder')
+			.should('not.exist')
+
+		cy.intercept('PROPPATCH', '**/remote.php/dav/files/*/new%20folder').as('addToFavorites')
+		// open sidebar
+		triggerActionForFile('new folder', 'details')
+		// open actions
+		cy.get('[data-cy-sidebar]')
+			.findByRole('button', { name: 'Actions' })
+			.click()
+		// trigger menu button
+		cy.findAllByRole('menu')
+			.findByRole('menuitem', { name: 'Add to favorites' })
+			.should('be.visible')
+			.click()
+		cy.wait('@addToFavorites')
+
+		// See favorites star
+		getRowForFile('new folder')
+			.findByRole('img', { name: 'Favorite' })
+			.should('be.visible')
+
+		// See folder in navigation
+		cy.get('[data-cy-files-navigation-item="favorites"]')
+			.should('be.visible')
+			.contains('new folder')
+			.should('exist')
+	})
+})
-- 
cgit v1.2.3