From 9ff51aafc518460e6c45996f09e9fe74e5f8d2e8 Mon Sep 17 00:00:00 2001 From: Morris Jobke Date: Thu, 25 Jan 2018 22:26:47 +0100 Subject: Use index based string access for substr with length of 1 Signed-off-by: Morris Jobke --- lib/private/App/AppStore/Version/VersionParser.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'lib/private/App/AppStore/Version/VersionParser.php') diff --git a/lib/private/App/AppStore/Version/VersionParser.php b/lib/private/App/AppStore/Version/VersionParser.php index 3924b8aea16..cdbb62ffbc5 100644 --- a/lib/private/App/AppStore/Version/VersionParser.php +++ b/lib/private/App/AppStore/Version/VersionParser.php @@ -63,11 +63,10 @@ class VersionParser { if(!$this->isValidVersionString($firstVersionNumber)) { break; } - if(substr($firstVersion, 0, 1) === '>') { + if(strpos($firstVersion, '>') === 0) { return new Version($firstVersionNumber, ''); - } else { - return new Version('', $firstVersionNumber); } + return new Version('', $firstVersionNumber); case 2: if(!$this->isValidVersionString($firstVersionNumber) || !$this->isValidVersionString($secondVersionNumber)) { break; -- cgit v1.2.3