From 0c2b17c80f54027aaebbc43b8efb21fdaffe8d45 Mon Sep 17 00:00:00 2001
From: Lukas Reschke <lukas@statuscode.ch>
Date: Fri, 7 Oct 2016 21:15:52 +0200
Subject: Cache AppInfo in Memory Cache if configured

This saves around 20ms on a bare-bone instance, on bigger ones more (depending on the number of installed apps).

See https://blackfire.io/profiles/compare/fc326ad3-100d-49b8-8ea9-8343240f53f3/graph

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
---
 lib/private/App/InfoParser.php | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

(limited to 'lib/private/App/InfoParser.php')

diff --git a/lib/private/App/InfoParser.php b/lib/private/App/InfoParser.php
index 3c14fe7c0cf..fbeb932763e 100644
--- a/lib/private/App/InfoParser.php
+++ b/lib/private/App/InfoParser.php
@@ -1,6 +1,7 @@
 <?php
 /**
  * @copyright Copyright (c) 2016, ownCloud, Inc.
+ * @copyright Copyright (c) 2016, Lukas Reschke <lukas@statuscode.ch>
  *
  * @author Andreas Fischer <bantu@owncloud.com>
  * @author Christoph Wurst <christoph@owncloud.com>
@@ -26,7 +27,18 @@
 
 namespace OC\App;
 
+use OCP\ICache;
+
 class InfoParser {
+	/** @var \OCP\ICache|null */
+	private $cache;
+
+	/**
+	 * @param ICache|null $cache
+	 */
+	public function __construct(ICache $cache = null) {
+		$this->cache = $cache;
+	}
 
 	/**
 	 * @param string $file the xml file to be loaded
@@ -37,6 +49,13 @@ class InfoParser {
 			return null;
 		}
 
+		if(!is_null($this->cache)) {
+			$fileCacheKey = $file . filemtime($file);
+			if ($cachedValue = $this->cache->get($fileCacheKey)) {
+				return json_decode($cachedValue, true);
+			}
+		}
+
 		libxml_use_internal_errors(true);
 		$loadEntities = libxml_disable_entity_loader(false);
 		$xml = simplexml_load_file($file);
@@ -119,6 +138,10 @@ class InfoParser {
 		if (isset($array['background-jobs']['job']) && is_array($array['background-jobs']['job'])) {
 			$array['background-jobs'] = $array['background-jobs']['job'];
 		}
+
+		if(!is_null($this->cache)) {
+			$this->cache->set($fileCacheKey, json_encode($array));
+		}
 		return $array;
 	}
 
-- 
cgit v1.2.3