From 33837e7d6fb57d657a197a4f49549d919b1ebc62 Mon Sep 17 00:00:00 2001 From: Benjamin Gaussorgues Date: Wed, 15 Nov 2023 10:13:57 +0100 Subject: Fix invalid users/groups handling in advanced search Signed-off-by: Benjamin Gaussorgues --- lib/private/Search/Filter/GroupFilter.php | 5 +++-- lib/private/Search/Filter/UserFilter.php | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) (limited to 'lib/private/Search') diff --git a/lib/private/Search/Filter/GroupFilter.php b/lib/private/Search/Filter/GroupFilter.php index 6b42492824c..f0b34a360ca 100644 --- a/lib/private/Search/Filter/GroupFilter.php +++ b/lib/private/Search/Filter/GroupFilter.php @@ -38,10 +38,11 @@ class GroupFilter implements IFilter { string $value, IGroupManager $groupManager, ) { - $this->group = $groupManager->get($value); - if ($this->group === null) { + $group = $groupManager->get($value); + if ($group === null) { throw new InvalidArgumentException('Group '.$value.' not found'); } + $this->group = $group; } public function get(): IGroup { diff --git a/lib/private/Search/Filter/UserFilter.php b/lib/private/Search/Filter/UserFilter.php index 1624b60d1a3..963d5e123ac 100644 --- a/lib/private/Search/Filter/UserFilter.php +++ b/lib/private/Search/Filter/UserFilter.php @@ -38,10 +38,11 @@ class UserFilter implements IFilter { string $value, IUserManager $userManager, ) { - $this->user = $userManager->get($value); - if ($this->user === null) { + $user = $userManager->get($value); + if ($user === null) { throw new InvalidArgumentException('User '.$value.' not found'); } + $this->user = $user; } public function get(): IUser { -- cgit v1.2.3