From 358eaba7dd45e5c5dbce44011bd7eadd88fe8534 Mon Sep 17 00:00:00 2001 From: Lukas Reschke Date: Mon, 13 Sep 2021 10:43:01 +0200 Subject: Apply suggestions from code review Signed-off-by: Lukas Reschke Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> --- .../Security/RateLimiting/Backend/DatabaseBackend.php | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) (limited to 'lib/private/Security') diff --git a/lib/private/Security/RateLimiting/Backend/DatabaseBackend.php b/lib/private/Security/RateLimiting/Backend/DatabaseBackend.php index 2ba6dc73c47..5f579bfef85 100644 --- a/lib/private/Security/RateLimiting/Backend/DatabaseBackend.php +++ b/lib/private/Security/RateLimiting/Backend/DatabaseBackend.php @@ -73,21 +73,19 @@ class DatabaseBackend implements IBackend { $qb = $this->dbConnection->getQueryBuilder(); $qb->delete(self::TABLE_NAME) ->where( - $qb->expr()->lte('delete_after', $qb->createParameter('currentTime')) - ) - ->setParameter('currentTime', $currentTime, 'datetime') + $qb->expr()->lte('delete_after', $qb->createNamedParameter($currentTime, IQueryBuilder::PARAM_DATE)) + ); ->executeStatement(); $qb = $this->dbConnection->getQueryBuilder(); - $qb->selectAlias($qb->createFunction('COUNT(*)'), 'count') + $qb->select($qb->func()->count()) ->from(self::TABLE_NAME) ->where( $qb->expr()->eq('hash', $qb->createNamedParameter($identifier, IQueryBuilder::PARAM_STR)) ) ->andWhere( - $qb->expr()->gte('delete_after', $qb->createParameter('currentTime')) - ) - ->setParameter('currentTime', $currentTime, 'datetime'); + $qb->expr()->gte('delete_after', $qb->createNamedParameter($currentTime, IQueryBuilder::PARAM_DATE)) + ); $cursor = $qb->executeQuery(); $row = $cursor->fetch(); -- cgit v1.2.3