From 7a14f94ae5cc8d02d46294ca5079c929877c2fe4 Mon Sep 17 00:00:00 2001 From: voxsim Date: Thu, 18 Sep 2014 17:50:19 +0200 Subject: 1. remove sizeof($filteredUsers) > 0 as condition 2. use count instead of sizeof. Latter is an alias to first one, practically we stick to count everywhere. Having it consistent helps with readability. 3. move whitespace so we have $groupUsers[] = $filteredUser; instead of $groupUsers []= $filteredUser; --- lib/private/group/manager.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/private/group') diff --git a/lib/private/group/manager.php b/lib/private/group/manager.php index e3744ab7698..da598f0c334 100644 --- a/lib/private/group/manager.php +++ b/lib/private/group/manager.php @@ -225,11 +225,11 @@ class Manager extends PublicEmitter { $filteredUsers = $this->userManager->search($search, $searchLimit, $searchOffset); foreach($filteredUsers as $filteredUser) { if($group->inGroup($filteredUser)) { - $groupUsers []= $filteredUser; + $groupUsers[]= $filteredUser; } } $searchOffset += $searchLimit; - } while(sizeof($groupUsers) < $searchLimit+$offset && sizeof($filteredUsers) > 0 && sizeof($filteredUsers) === $searchLimit); + } while(count($groupUsers) < $searchLimit+$offset && count($filteredUsers) === $searchLimit); if($limit === -1) { $groupUsers = array_slice($groupUsers, $offset); -- cgit v1.2.3