From d4dec43f8fec7430840e878b698a6c62e09fd915 Mon Sep 17 00:00:00 2001 From: Daniel Kesselberg Date: Sat, 29 Sep 2018 20:23:24 +0200 Subject: Dont use find to lookup binaries Signed-off-by: Daniel Kesselberg --- lib/private/legacy/helper.php | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) (limited to 'lib/private/legacy') diff --git a/lib/private/legacy/helper.php b/lib/private/legacy/helper.php index 8373c191dce..5a05e147c2b 100644 --- a/lib/private/legacy/helper.php +++ b/lib/private/legacy/helper.php @@ -505,20 +505,7 @@ class OC_Helper { if (self::is_function_enabled('exec')) { $exeSniffer = new ExecutableFinder(); // Returns null if nothing is found - $result = $exeSniffer->find($program); - if (empty($result)) { - $paths = getenv('PATH'); - if (empty($paths)) { - $paths = '/usr/local/bin /usr/bin /opt/bin /bin'; - } else { - $paths = str_replace(':',' ',getenv('PATH')); - } - $command = 'find ' . $paths . ' -name ' . escapeshellarg($program) . ' 2> /dev/null'; - exec($command, $output, $returnCode); - if (count($output) > 0) { - $result = escapeshellcmd($output[0]); - } - } + $result = $exeSniffer->find($program, null, ['/usr/local/sbin', '/usr/local/bin', '/usr/sbin', '/usr/bin', '/sbin', '/bin', '/opt/bin']); } // store the value for 5 minutes $memcache->set($program, $result, 300); -- cgit v1.2.3