From 165afb004b68d0429c6e65e296a4508308929f26 Mon Sep 17 00:00:00 2001 From: Lukas Reschke Date: Tue, 24 Feb 2015 11:49:40 +0100 Subject: Use getRemoteAddress which supports reverse proxies Breaking change for 8.1 wiki (Security > Administrators): The log format for failed logins has changed and uses now the remote address and is considering reverse proxies for such scenarios when configured correctly. --- lib/private/user/manager.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'lib/private/user/manager.php') diff --git a/lib/private/user/manager.php b/lib/private/user/manager.php index 33858dfd9dd..c965b22edbc 100644 --- a/lib/private/user/manager.php +++ b/lib/private/user/manager.php @@ -181,10 +181,7 @@ class Manager extends PublicEmitter implements IUserManager { } } - $remoteAddr = isset($_SERVER['REMOTE_ADDR']) ? $_SERVER['REMOTE_ADDR'] : ''; - $forwardedFor = isset($_SERVER['HTTP_X_FORWARDED_FOR']) ? $_SERVER['HTTP_X_FORWARDED_FOR'] : ''; - - \OC::$server->getLogger()->warning('Login failed: \''. $loginname .'\' (Remote IP: \''. $remoteAddr .'\', X-Forwarded-For: \''. $forwardedFor .'\')', array('app' => 'core')); + \OC::$server->getLogger()->warning('Login failed: \''. $loginname .'\' (Remote IP: \''. \OC::$server->getRequest()->getRemoteAddress(). ')', ['app' => 'core']); return false; } -- cgit v1.2.3