From 3cce9aa547d44cdb9ead142bb792a67be789b0e9 Mon Sep 17 00:00:00 2001 From: Côme Chilliet Date: Thu, 1 Dec 2022 11:41:54 +0100 Subject: Just use string for groups in enableAppForGroups MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Côme Chilliet --- lib/private/App/AppManager.php | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) (limited to 'lib/private') diff --git a/lib/private/App/AppManager.php b/lib/private/App/AppManager.php index 6d2fe51d0ed..3b352001dac 100644 --- a/lib/private/App/AppManager.php +++ b/lib/private/App/AppManager.php @@ -52,7 +52,6 @@ use Psr\Log\LoggerInterface; use Symfony\Component\EventDispatcher\EventDispatcherInterface; class AppManager implements IAppManager { - /** * Apps with these types can not be enabled for certain groups only * @var string[] @@ -184,7 +183,7 @@ class AppManager implements IAppManager { /** * @param string $appId - * @return array + * @return string[] */ public function getAppRestriction(string $appId): array { $values = $this->getInstalledAppsValues(); @@ -346,7 +345,7 @@ class AppManager implements IAppManager { * Enable an app only for specific groups * * @param string $appId - * @param \OCP\IGroup[] $groups + * @param string[] $groups * @param bool $forceEnable * @throws \InvalidArgumentException if app can't be enabled for groups * @throws AppPathNotFoundException @@ -364,15 +363,8 @@ class AppManager implements IAppManager { $this->ignoreNextcloudRequirementForApp($appId); } - $groupIds = array_map(function ($group) { - /** @var \OCP\IGroup $group */ - return ($group instanceof IGroup) - ? $group->getGID() - : $group; - }, $groups); - - $this->installedAppsCache[$appId] = json_encode($groupIds); - $this->appConfig->setValue($appId, 'enabled', json_encode($groupIds)); + $this->installedAppsCache[$appId] = json_encode($groups); + $this->appConfig->setValue($appId, 'enabled', json_encode($groups)); $this->dispatcher->dispatch(ManagerEvent::EVENT_APP_ENABLE_FOR_GROUPS, new ManagerEvent( ManagerEvent::EVENT_APP_ENABLE_FOR_GROUPS, $appId, $groups )); -- cgit v1.2.3