From 6c349c00bb7ce3c43a44588de5cf158158d2990b Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Fri, 13 Feb 2015 11:51:55 +0100 Subject: Order methods to by grouped by their task --- lib/public/activity/iextension.php | 38 +++++++++++++++++++------------------- lib/public/activity/imanager.php | 24 ++++++++++++------------ 2 files changed, 31 insertions(+), 31 deletions(-) (limited to 'lib/public/activity') diff --git a/lib/public/activity/iextension.php b/lib/public/activity/iextension.php index 1b405ad8d3d..0f6c3c5f8a5 100644 --- a/lib/public/activity/iextension.php +++ b/lib/public/activity/iextension.php @@ -46,16 +46,6 @@ interface IExtension { */ public function getNotificationTypes($languageCode); - /** - * The extension can filter the types based on the filter if required. - * In case no filter is to be applied false is to be returned unchanged. - * - * @param array $types - * @param string $filter - * @return array|false - */ - public function filterNotificationTypes($types, $filter); - /** * For a given method additional types to be displayed in the settings can be returned. * In case no additional types are to be added false is to be returned. @@ -65,6 +55,15 @@ interface IExtension { */ public function getDefaultTypes($method); + /** + * A string naming the css class for the icon to be used can be returned. + * If no icon is known for the given type false is to be returned. + * + * @param string $type + * @return string|false + */ + public function getTypeIcon($type); + /** * The extension can translate a given message to the requested languages. * If no translation is available false is to be returned. @@ -92,15 +91,6 @@ interface IExtension { */ function getSpecialParameterList($app, $text); - /** - * A string naming the css class for the icon to be used can be returned. - * If no icon is known for the given type false is to be returned. - * - * @param string $type - * @return string|false - */ - public function getTypeIcon($type); - /** * The extension can define the parameter grouping by returning the index as integer. * In case no grouping is required false is to be returned. @@ -127,6 +117,16 @@ interface IExtension { */ public function isFilterValid($filterValue); + /** + * The extension can filter the types based on the filter if required. + * In case no filter is to be applied false is to be returned unchanged. + * + * @param array $types + * @param string $filter + * @return array|false + */ + public function filterNotificationTypes($types, $filter); + /** * For a given filter the extension can specify the sql query conditions including parameters for that query. * In case the extension does not know the filter false is to be returned. diff --git a/lib/public/activity/imanager.php b/lib/public/activity/imanager.php index a08670be4b0..4a07e6912b0 100644 --- a/lib/public/activity/imanager.php +++ b/lib/public/activity/imanager.php @@ -76,17 +76,16 @@ interface IManager { function getNotificationTypes($languageCode); /** - * @param array $types - * @param string $filter + * @param string $method * @return array */ - function filterNotificationTypes($types, $filter); + function getDefaultTypes($method); /** - * @param string $method - * @return array + * @param string $type + * @return string */ - function getDefaultTypes($method); + function getTypeIcon($type); /** * @param string $app @@ -106,12 +105,6 @@ interface IManager { */ function getSpecialParameterList($app, $text); - /** - * @param string $type - * @return string - */ - function getTypeIcon($type); - /** * @param array $activity * @return integer|false @@ -129,6 +122,13 @@ interface IManager { */ function isFilterValid($filterValue); + /** + * @param array $types + * @param string $filter + * @return array + */ + function filterNotificationTypes($types, $filter); + /** * @param string $filter * @return array -- cgit v1.2.3