From 21cfd1014a99e25f4ee255b872957fc1b98a7610 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Tue, 10 Jun 2014 15:26:18 +0200 Subject: Repair broken parent link in the scanner --- lib/private/files/cache/scanner.php | 70 +++++++++++++++++++------------------ 1 file changed, 36 insertions(+), 34 deletions(-) (limited to 'lib') diff --git a/lib/private/files/cache/scanner.php b/lib/private/files/cache/scanner.php index 965013c5c98..1f67ce0062c 100644 --- a/lib/private/files/cache/scanner.php +++ b/lib/private/files/cache/scanner.php @@ -100,45 +100,47 @@ class Scanner extends BasicEmitter { \OC_Hook::emit('\OC\Files\Cache\Scanner', 'scan_file', array('path' => $file, 'storage' => $this->storageId)); $data = $this->getData($file); if ($data) { - if ($file and !$parentExistsInCache) { - $parent = dirname($file); - if ($parent === '.' or $parent === '/') { - $parent = ''; - } - if (!$this->cache->inCache($parent)) { - $this->scanFile($parent); - } + $parent = dirname($file); + if ($parent === '.' or $parent === '/') { + $parent = ''; + } + $parentId = $this->cache->getId($parent); + if ($file and $parentId === -1) { + $parentData = $this->scanFile($parent); + $parentId = $parentData['fileid']; + } + if ($parent) { + $data['parent'] = $parentId; } - $newData = $data; $cacheData = $this->cache->get($file); - if ($cacheData) { - if ($reuseExisting) { - // prevent empty etag - if (empty($cacheData['etag'])) { - $etag = $data['etag']; - } else { - $etag = $cacheData['etag']; - } - // only reuse data if the file hasn't explicitly changed - if (isset($data['storage_mtime']) && isset($cacheData['storage_mtime']) && $data['storage_mtime'] === $cacheData['storage_mtime']) { - $data['mtime'] = $cacheData['mtime']; - if (($reuseExisting & self::REUSE_SIZE) && ($data['size'] === -1)) { - $data['size'] = $cacheData['size']; - } - if ($reuseExisting & self::REUSE_ETAG) { - $data['etag'] = $etag; - } + if ($cacheData and $reuseExisting) { + // prevent empty etag + if (empty($cacheData['etag'])) { + $etag = $data['etag']; + } else { + $etag = $cacheData['etag']; + } + // only reuse data if the file hasn't explicitly changed + if (isset($data['storage_mtime']) && isset($cacheData['storage_mtime']) && $data['storage_mtime'] === $cacheData['storage_mtime']) { + $data['mtime'] = $cacheData['mtime']; + if (($reuseExisting & self::REUSE_SIZE) && ($data['size'] === -1)) { + $data['size'] = $cacheData['size']; } - // Only update metadata that has changed - $newData = array_diff_assoc($data, $cacheData); - if (isset($newData['etag'])) { - $cacheDataString = print_r($cacheData, true); - $dataString = print_r($data, true); - \OCP\Util::writeLog('OC\Files\Cache\Scanner', - "!!! No reuse of etag for '$file' !!! \ncache: $cacheDataString \ndata: $dataString", - \OCP\Util::DEBUG); + if ($reuseExisting & self::REUSE_ETAG) { + $data['etag'] = $etag; } } + // Only update metadata that has changed + $newData = array_diff_assoc($data, $cacheData); + if (isset($newData['etag'])) { + $cacheDataString = print_r($cacheData, true); + $dataString = print_r($data, true); + \OCP\Util::writeLog('OC\Files\Cache\Scanner', + "!!! No reuse of etag for '$file' !!! \ncache: $cacheDataString \ndata: $dataString", + \OCP\Util::DEBUG); + } + } else { + $newData = $data; } if (!empty($newData)) { $data['fileid'] = $this->addToCache($file, $newData); -- cgit v1.2.3