From 7d389b26f94c130fc6bd8958edb80e07048e89b2 Mon Sep 17 00:00:00 2001 From: Thomas Müller <thomas.mueller@tmit.eu> Date: Fri, 26 Sep 2014 09:17:47 +0200 Subject: catch and log exception in OC_Helper::cleanTmp() --- lib/private/helper.php | 24 +++++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) (limited to 'lib') diff --git a/lib/private/helper.php b/lib/private/helper.php index 8764a6b35d9..33233225e73 100644 --- a/lib/private/helper.php +++ b/lib/private/helper.php @@ -643,15 +643,33 @@ class OC_Helper { if (file_exists($leftoversFile)) { $leftovers = file($leftoversFile); foreach ($leftovers as $file) { - self::rmdirr($file); + try { + self::rmdirr($file); + } catch (UnexpectedValueException $ex) { + // not really much we can do here anymore + if (!is_null(\OC::$server)) { + $message = $ex->getMessage(); + \OC::$server->getLogger()->error("Error deleting file/folder: $file - Reason: $message", + array('app' => 'core')); + } + } } unlink($leftoversFile); } foreach (self::$tmpFiles as $file) { if (file_exists($file)) { - if (!self::rmdirr($file)) { - file_put_contents($leftoversFile, $file . "\n", FILE_APPEND); + try { + if (!self::rmdirr($file)) { + file_put_contents($leftoversFile, $file . "\n", FILE_APPEND); + } + } catch (UnexpectedValueException $ex) { + // not really much we can do here anymore + if (!is_null(\OC::$server)) { + $message = $ex->getMessage(); + \OC::$server->getLogger()->error("Error deleting file/folder: $file - Reason: $message", + array('app' => 'core')); + } } } } -- cgit v1.2.3