"
data-displayName="">
+
+ "> |
+
|
$displayName) {
$users[] = array(
"name" => $uid,
+ "avatar" => \OC_Avatar::get($uid, 32),
"displayName" => $displayName,
"groups" => OC_Group::getUserGroups($uid),
'quota' => $quota,
--
cgit v1.2.3
From 2bfe66223563b16a067be273e0d6979b420598ad Mon Sep 17 00:00:00 2001
From: kondou
Date: Tue, 30 Jul 2013 16:09:54 +0200
Subject: Add unittests & check filetype in setLocalAvatar()
TODO: Fix OC_Image->mimetype(), it always returns "image/png"
---
lib/avatar.php | 10 ++++++--
settings/ajax/newavatar.php | 10 +++-----
tests/data/testavatar.png | Bin 0 -> 3705 bytes
tests/lib/avatar.php | 61 ++++++++++++++++++++++++++++++++++++++++++++
4 files changed, 73 insertions(+), 8 deletions(-)
create mode 100644 tests/data/testavatar.png
create mode 100644 tests/lib/avatar.php
(limited to 'lib')
diff --git a/lib/avatar.php b/lib/avatar.php
index b232e9be762..f3db07142ca 100644
--- a/lib/avatar.php
+++ b/lib/avatar.php
@@ -43,11 +43,11 @@ class OC_Avatar {
* @brief sets the users local avatar
* @param $user string user to set the avatar for
* @param $img mixed imagedata to set a new avatar, or false to delete the current avatar
- * @param $type string fileextension
+ * @throws Exception if the provided file is not a jpg or png image
* @throws Exception if the provided image is not valid, or not a square
* @return true on success
*/
- public static function setLocalAvatar ($user, $img, $type) {
+ public static function setLocalAvatar ($user, $img) {
$view = new \OC\Files\View('/'.$user);
if ($img === false) {
@@ -56,6 +56,12 @@ class OC_Avatar {
return true;
} else {
$img = new OC_Image($img);
+ // FIXME this always says "image/png"
+ $type = substr($img->mimeType(), -3);
+ if ($type === 'peg') { $type = 'jpg'; }
+ if ($type !== 'jpg' && $type !== 'png') {
+ throw new Exception();
+ }
if (!( $img->valid() && ($img->height() === $img->width()) )) {
throw new Exception();
diff --git a/settings/ajax/newavatar.php b/settings/ajax/newavatar.php
index b52317c9678..456cd84e970 100644
--- a/settings/ajax/newavatar.php
+++ b/settings/ajax/newavatar.php
@@ -7,18 +7,16 @@ $user = OC_User::getUser();
if(isset($_POST['path'])) {
$path = $_POST['path'];
if ($path === "false") { // delete avatar
- \OC_Avatar::setLocalAvatar($user, false, false);
+ \OC_Avatar::setLocalAvatar($user, false);
} else { // select an image from own files
$view = new \OC\Files\View('/'.$user.'/files');
$img = $view->file_get_contents($path);
$type = substr($path, -3);
- if ($type === 'peg') { $type = 'jpg'; }
-
- if ($type === 'jpg' or $type === 'png') {
- \OC_Avatar::setLocalAvatar($user, $img, $type);
+ try {
+ \OC_Avatar::setLocalAvatar($user, $img);
OC_JSON::success();
- } else {
+ } catch (Exception $e) {
OC_JSON::error();
}
}
diff --git a/tests/data/testavatar.png b/tests/data/testavatar.png
new file mode 100644
index 00000000000..24770fb634f
Binary files /dev/null and b/tests/data/testavatar.png differ
diff --git a/tests/lib/avatar.php b/tests/lib/avatar.php
new file mode 100644
index 00000000000..b1d9f46ed09
--- /dev/null
+++ b/tests/lib/avatar.php
@@ -0,0 +1,61 @@
+
+ * This file is licensed under the Affero General Public License version 3 or
+ * later.
+ * See the COPYING-README file.
+ */
+
+class Test_Avatar extends PHPUnit_Framework_TestCase {
+
+ public function testModes() {
+ $this->assertEquals('local', \OC_Avatar::getMode());
+
+ \OC_Config::setValue('avatar', 'local');
+ $this->assertEquals('local', \OC_Avatar::getMode());
+
+ \OC_Config::setValue('avatar', 'gravatar');
+ $this->assertEquals('gravatar', \OC_Avatar::getMode());
+
+ \OC_Config::setValue('avatar', 'none');
+ $this->assertEquals('none', \OC_Avatar::getMode());
+ }
+
+ public function testDisabledAvatar() {
+ \OC_Config::setValue('avatar', 'none');
+ $this->assertFalse(\OC_Avatar::get(\OC_User::getUser()));
+ $this->assertFalse(\OC_Avatar::get(\OC_User::getUser(), 32));
+ }
+
+ public function testLocalAvatar() {
+ \OC_Config::setValue('avatar', 'local');
+ $this->assertEquals(\OC_Avatar::get(\OC_User::getUser()), \OC_Avatar::wrapIntoImg(\OC_Avatar::getDefaultAvatar(), 'png'));
+
+ $expected = new OC_Image(\OC::$SERVERROOT.'/tests/data/testavatar.png');
+ \OC_Avatar::setLocalAvatar(\OC_User::getUser(), $expected->data());
+ $expected->resize(32);
+ $this->assertEquals($expected, \OC_Avatar::get(\OC_User::getUser()));
+
+ \OC_Avatar::setLocalAvatar(\OC_User::getUser(), false);
+ $this->assertEquals(\OC_Avatar::get(\OC_User::getUser()), \OC_Avatar::wrapIntoImg(\OC_Avatar::getDefaultAvatar(), 'png'));
+ }
+
+ public function testGravatar() {
+ \OC_Preferences::setValue(\OC_User::getUser(), 'settings', 'email', 'someone@example.com');
+ \OC_Config::setValue('avatar', 'gravatar');
+ $expected = "http://www.gravatar.com/avatar/".md5("someone@example.com")."?s=";
+ $this->assertEquals($expected."64", \OC_Avatar::get(\OC_User::getUser()));
+ $this->assertEquals($expected."32", \OC_Avatar::get(\OC_User::getUser(), 32));
+ }
+
+ public function testDefaultAvatar() {
+ $img = new \OC_Image(OC::$SERVERROOT.'/core/img/defaultavatar.png');
+ $img->resize(128);
+ $this->assertEquals((string)$img, \OC_Avatar::getDefaultAvatar(128));
+ }
+
+ public function testWrapIntoImg() {
+ $expected = "data:image/test;base64,DUMMY==123==";
+ $this->assertEquals($expected, \OC_Avatar::wrapIntoImg("DUMMY==123==", "test"));
+ }
+}
--
cgit v1.2.3
From a58d270684110334aab1b296b69e98def6cc6558 Mon Sep 17 00:00:00 2001
From: kondou
Date: Thu, 1 Aug 2013 17:13:11 +0200
Subject: Load avatar from path, if one's provided
---
lib/avatar.php | 12 ++++++------
settings/ajax/newavatar.php | 10 +++-------
2 files changed, 9 insertions(+), 13 deletions(-)
(limited to 'lib')
diff --git a/lib/avatar.php b/lib/avatar.php
index f3db07142ca..dcaf81f0349 100644
--- a/lib/avatar.php
+++ b/lib/avatar.php
@@ -42,21 +42,21 @@ class OC_Avatar {
/**
* @brief sets the users local avatar
* @param $user string user to set the avatar for
- * @param $img mixed imagedata to set a new avatar, or false to delete the current avatar
+ * @param $data mixed imagedata or path to set a new avatar, or false to delete the current avatar
* @throws Exception if the provided file is not a jpg or png image
* @throws Exception if the provided image is not valid, or not a square
* @return true on success
*/
- public static function setLocalAvatar ($user, $img) {
+ public static function setLocalAvatar ($user, $data) {
$view = new \OC\Files\View('/'.$user);
- if ($img === false) {
+ if ($data === false) {
$view->unlink('avatar.jpg');
$view->unlink('avatar.png');
return true;
} else {
- $img = new OC_Image($img);
- // FIXME this always says "image/png"
+ $img = new OC_Image($data);
+ // FIXME this always says "image/png", when loading from data
$type = substr($img->mimeType(), -3);
if ($type === 'peg') { $type = 'jpg'; }
if ($type !== 'jpg' && $type !== 'png') {
@@ -69,7 +69,7 @@ class OC_Avatar {
$view->unlink('avatar.jpg');
$view->unlink('avatar.png');
- $view->file_put_contents('avatar.'.$type, $img);
+ $view->file_put_contents('avatar.'.$type, $data);
return true;
}
}
diff --git a/settings/ajax/newavatar.php b/settings/ajax/newavatar.php
index 456cd84e970..4c8ff0c4169 100644
--- a/settings/ajax/newavatar.php
+++ b/settings/ajax/newavatar.php
@@ -5,16 +5,12 @@ OC_JSON::callCheck();
$user = OC_User::getUser();
if(isset($_POST['path'])) {
- $path = $_POST['path'];
- if ($path === "false") { // delete avatar
+ if ($_POST['path'] === "false") { // delete avatar
\OC_Avatar::setLocalAvatar($user, false);
} else { // select an image from own files
- $view = new \OC\Files\View('/'.$user.'/files');
- $img = $view->file_get_contents($path);
-
- $type = substr($path, -3);
try {
- \OC_Avatar::setLocalAvatar($user, $img);
+ $path = OC::$SERVERROOT.'/data/'.$user.'/files'.$_POST['path'];
+ \OC_Avatar::setLocalAvatar($user, $path);
OC_JSON::success();
} catch (Exception $e) {
OC_JSON::error();
--
cgit v1.2.3
From 252548c62cf099e5186ffc323e3cf9494fae3768 Mon Sep 17 00:00:00 2001
From: kondou
Date: Fri, 2 Aug 2013 08:03:51 +0200
Subject: Improve styling & enable avatar-upload at personal page
---
core/css/styles.css | 5 +++++
core/templates/layout.user.php | 4 +++-
lib/templatelayout.php | 2 +-
settings/ajax/newavatar.php | 15 +++++++++++----
settings/css/settings.css | 3 +++
settings/js/personal.js | 8 ++++++++
settings/personal.php | 3 +++
settings/templates/admin.php | 21 ++++++++-------------
settings/templates/personal.php | 2 +-
tests/lib/avatar.php | 2 +-
10 files changed, 44 insertions(+), 21 deletions(-)
(limited to 'lib')
diff --git a/core/css/styles.css b/core/css/styles.css
index 367f3f7ca41..792ccb08329 100644
--- a/core/css/styles.css
+++ b/core/css/styles.css
@@ -40,6 +40,11 @@ body { background:#fefefe; font:normal .8em/1.6em "Helvetica Neue",Helvetica,Ari
.header-right { float:right; vertical-align:middle; padding:0.5em; }
.header-right > * { vertical-align:middle; }
+header .avatar {
+ float:right;
+ margin-top: 6px;
+ margin-right: 6px;
+}
/* INPUTS */
input[type="text"], input[type="password"], input[type="search"], input[type="number"], input[type="email"], input[type="url"],
diff --git a/core/templates/layout.user.php b/core/templates/layout.user.php
index 038264bd064..0ab6a4dc08b 100644
--- a/core/templates/layout.user.php
+++ b/core/templates/layout.user.php
@@ -45,9 +45,11 @@
getLogoClaim()); ?>
+
+
+
-
diff --git a/lib/templatelayout.php b/lib/templatelayout.php
index f24cd9cfd9e..c26dff4176c 100644
--- a/lib/templatelayout.php
+++ b/lib/templatelayout.php
@@ -20,7 +20,7 @@ class OC_TemplateLayout extends OC_Template {
// display avatars if they are enabled
if (OC_Config::getValue('avatar') === 'gravatar' || OC_Config::getValue('avatar', 'local') === 'local') {
- $this->assign('avatar', ' ');
+ $this->assign('avatar', ' ');
}
// Update notification
diff --git a/settings/ajax/newavatar.php b/settings/ajax/newavatar.php
index 4c8ff0c4169..bede15e499d 100644
--- a/settings/ajax/newavatar.php
+++ b/settings/ajax/newavatar.php
@@ -13,12 +13,19 @@ if(isset($_POST['path'])) {
\OC_Avatar::setLocalAvatar($user, $path);
OC_JSON::success();
} catch (Exception $e) {
- OC_JSON::error();
+ OC_JSON::error(array("msg" => $e->getMessage()));
}
}
-} elseif (isset($_POST['image'])) { // upload a new image
- \OC_Avatar::setLocalAvatar($user, $_POST['image']);
- OC_JSON::success();
+} elseif (!empty($_FILES)) { // upload a new image
+ $files = $_FILES['files'];
+ if ($files['error'][0] === 0) {
+ $data = file_get_contents($files['tmp_name'][0]);
+ \OC_Avatar::setLocalAvatar($user, $data);
+ unlink($files['tmp_name'][0]);
+ OC_JSON::success();
+ } else {
+ OC_JSON::error();
+ }
} else {
OC_JSON::error();
}
diff --git a/settings/css/settings.css b/settings/css/settings.css
index d5ffe448482..e6ced0e375a 100644
--- a/settings/css/settings.css
+++ b/settings/css/settings.css
@@ -35,6 +35,9 @@ td.name, td.password { padding-left:.8em; }
td.password>img,td.displayName>img, td.remove>a, td.quota>img { visibility:hidden; }
td.password, td.quota, td.displayName { width:12em; cursor:pointer; }
td.password>span, td.quota>span, rd.displayName>span { margin-right: 1.2em; color: #C7C7C7; }
+td.avatar img {
+ margin-top: 6px;
+}
td.remove { width:1em; padding-right:1em; }
tr:hover>td.password>span, tr:hover>td.displayName>span { margin:0; cursor:pointer; }
diff --git a/settings/js/personal.js b/settings/js/personal.js
index fdaca07e98d..71b4785bbf2 100644
--- a/settings/js/personal.js
+++ b/settings/js/personal.js
@@ -144,6 +144,14 @@ $(document).ready(function(){
updateAvatar();
});
+ var uploadparms = {
+ done: function(e) {
+ updateAvatar();
+ }
+ };
+
+ $('#uploadavatar').fileupload(uploadparms);
+
$('#selectavatar').click(function(){
OC.dialogs.filepicker(t('settings', "Select an avatar"), selectAvatar, false, "image");
});
diff --git a/settings/personal.php b/settings/personal.php
index 4bec21d58c8..233b1440eb2 100644
--- a/settings/personal.php
+++ b/settings/personal.php
@@ -15,6 +15,9 @@ OC_Util::addScript( 'settings', 'personal' );
OC_Util::addStyle( 'settings', 'settings' );
OC_Util::addScript( '3rdparty', 'chosen/chosen.jquery.min' );
OC_Util::addStyle( '3rdparty', 'chosen' );
+if (OC_Config::getValue('avatar', 'local') === 'local') {
+ \OC_Util::addScript('files', 'jquery.fileupload');
+}
OC_App::setActiveNavigationEntry( 'personal' );
$storageInfo=OC_Helper::getStorageInfo();
diff --git a/settings/templates/admin.php b/settings/templates/admin.php
index e5b941f2b2f..f7d6a576d9e 100644
--- a/settings/templates/admin.php
+++ b/settings/templates/admin.php
@@ -121,10 +121,9 @@ if (!$_['internetconnectionworking']) {
diff --git a/settings/templates/personal.php b/settings/templates/personal.php
index 01415a6f9a1..e0e91cb7de4 100644
--- a/settings/templates/personal.php
+++ b/settings/templates/personal.php
@@ -87,7 +87,7 @@ if($_['passwordChangeSupported']) {
|