From 59627367ae4ba41c84f14e55ef4fe57c2924b7ab Mon Sep 17 00:00:00 2001 From: Bart Visscher Date: Wed, 14 Nov 2012 21:44:44 +0100 Subject: Better check and handling of user creation --- settings/ajax/createuser.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'settings/ajax') diff --git a/settings/ajax/createuser.php b/settings/ajax/createuser.php index 16b48c8a9ca..addae78517a 100644 --- a/settings/ajax/createuser.php +++ b/settings/ajax/createuser.php @@ -29,14 +29,17 @@ $username = $_POST["username"]; $password = $_POST["password"]; // Does the group exist? -if( in_array( $username, OC_User::getUsers())) { +if(OC_User::userExists($username)) { OC_JSON::error(array("data" => array( "message" => "User already exists" ))); exit(); } // Return Success story try { - OC_User::createUser($username, $password); + if (!OC_User::createUser($username, $password)) { + OC_JSON::error(array('data' => array( 'message' => 'User creation failed for '.$username ))); + exit(); + } foreach( $groups as $i ) { if(!OC_Group::groupExists($i)) { OC_Group::createGroup($i); -- cgit v1.2.3