From 4b90429178f8a72e330356ffb743b02c1c1904a1 Mon Sep 17 00:00:00 2001 From: Lukas Reschke Date: Fri, 12 Feb 2016 11:11:39 +0100 Subject: Add note if integrity check is disabled Our issue template states that users should post the output of `/index.php/settings/integrity/failed`, at the moment it displays that all passes have been passed if the integrity checker has been disabled. This is however a wrong approach considering that some distributions are gonna package Frankenstein releases and makes it harder for us to detect such issues. Thus if the integrity code checker is disabled (using the config switch) it displays now: `Appcode checker has been disabled. Integrity cannot be verified.` This is not displayed anywhere else in the UI except these URL used for us for debugging purposes. --- settings/controller/checksetupcontroller.php | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'settings') diff --git a/settings/controller/checksetupcontroller.php b/settings/controller/checksetupcontroller.php index 26194bb1180..cfdfa5021bc 100644 --- a/settings/controller/checksetupcontroller.php +++ b/settings/controller/checksetupcontroller.php @@ -271,6 +271,10 @@ class CheckSetupController extends Controller { * @return DataResponse */ public function getFailedIntegrityCheckFiles() { + if(!$this->checker->isCodeCheckEnforced()) { + return new DataDisplayResponse('Integrity checker has been disabled. Integrity cannot be verified.'); + } + $completeResults = $this->checker->getResults(); if(!empty($completeResults)) { -- cgit v1.2.3