From 1993984769e4187f0229c31c46c94257a3bcb9b7 Mon Sep 17 00:00:00 2001 From: Greta Doci Date: Mon, 29 Jul 2019 10:25:46 +0200 Subject: Adjust acceptance tests to changes in link share menu behaviour Now the link share menu is not automatically opened after a link share is created, so waiting until it was opened failed in iShareTheLinkFor. Note that the steps that interact with the link share menu take care themselves of showing the menu if needed, so there is no need to explicitly show it despite the change. Also, the waiting in iShareTheLinkFor was introduced when the link share menu was changed to automatically open after creating a link share, as that caused some issues with the steps that opened the menu by themselves (fec8d12fc5). Due to all this, now that the link share menu is again not automatically opened the wait can be simply removed. Signed-off-by: Greta Doci --- tests/acceptance/features/bootstrap/FilesAppSharingContext.php | 8 -------- 1 file changed, 8 deletions(-) (limited to 'tests/acceptance') diff --git a/tests/acceptance/features/bootstrap/FilesAppSharingContext.php b/tests/acceptance/features/bootstrap/FilesAppSharingContext.php index 4ae8659d2d1..5353f05c110 100644 --- a/tests/acceptance/features/bootstrap/FilesAppSharingContext.php +++ b/tests/acceptance/features/bootstrap/FilesAppSharingContext.php @@ -249,14 +249,6 @@ class FilesAppSharingContext implements Context, ActorAwareInterface { $this->actor->find(FileListContext::shareActionForFile(FilesAppContext::currentSectionMainView(), $fileName), 10)->click(); $this->actor->find(self::shareLinkAddNewButton(), 5)->click(); - - // Wait until the menu was opened after the share creation to continue. - if (!WaitFor::elementToBeEventuallyShown( - $this->actor, - self::shareLinkMenu(), - $timeout = 5 * $this->actor->getFindTimeoutMultiplier())) { - PHPUnit_Framework_Assert::fail("The share link menu is not open yet after $timeout seconds"); - } } /** -- cgit v1.2.3