From 2ccf544ad7c8bfc54600adb065156f04a8912c9f Mon Sep 17 00:00:00 2001 From: Philipp Schaffrath Date: Tue, 10 Jan 2017 12:10:36 +0100 Subject: Fixed failing test which was ignoring a required (not null) column (#26303) * Fixed failing test which was ignoring a required (not null) column * restored test to original, catching DriverException which also catches ConstraintViolationException * catch ConstraintViolationException again * removed unnecessary field from this test * clobfield should be nullable * clobfield now is nullable * removed autoincrement since whenever this strategy is enabled, oracle would not throw constraint violation exceptions (needed for setValues), which mysql still does * this field does not auto increment anymore * mark integerfield as primary, since it is not getting marked as such through auto increment anymore, integerfield default always has been 0 instead of null Signed-off-by: Morris Jobke --- tests/lib/DB/ConnectionTest.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'tests/lib/DB/ConnectionTest.php') diff --git a/tests/lib/DB/ConnectionTest.php b/tests/lib/DB/ConnectionTest.php index b9c55c23339..2a0cd70f83a 100644 --- a/tests/lib/DB/ConnectionTest.php +++ b/tests/lib/DB/ConnectionTest.php @@ -124,8 +124,7 @@ class ConnectionTest extends \Test\TestCase { $this->connection->setValues('table', [ 'integerfield' => 1 ], [ - 'textfield' => 'foo', - 'clobfield' => 'not_null' + 'textfield' => 'foo' ]); $this->connection->setValues('table', [ -- cgit v1.2.3