From 733d4b6ccaeec30f931c23614b98013a1b2f674e Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Wed, 25 Sep 2019 18:07:32 +0200 Subject: dont delete cache entries if deleting an object from object store failed Signed-off-by: Robin Appelman --- .../Files/ObjectStore/ObjectStoreStorageTest.php | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) (limited to 'tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php') diff --git a/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php b/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php index 3b3827f460a..ce9c9d2cd69 100644 --- a/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php +++ b/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php @@ -181,4 +181,29 @@ class ObjectStoreStorageTest extends Storage { } $this->assertFalse($this->instance->file_exists('test.txt')); } + + public function testDeleteObjectFailureKeepCache() { + $objectStore = $this->instance->getObjectStore(); + $this->instance->setObjectStore(new FailDeleteObjectStore($objectStore)); + $cache = $this->instance->getCache(); + + $this->instance->file_put_contents('test.txt', 'foo'); + + $this->assertTrue($cache->inCache('test.txt')); + + $this->assertFalse($this->instance->unlink('test.txt')); + + $this->assertTrue($cache->inCache('test.txt')); + + $this->instance->mkdir('foo'); + $this->instance->file_put_contents('foo/test.txt', 'foo'); + + $this->assertTrue($cache->inCache('foo')); + $this->assertTrue($cache->inCache('foo/test.txt')); + + $this->instance->rmdir('foo'); + + $this->assertTrue($cache->inCache('foo')); + $this->assertTrue($cache->inCache('foo/test.txt')); + } } -- cgit v1.2.3