From 9e86d71cc533e84084a4dd5e440af0f5aa516108 Mon Sep 17 00:00:00 2001 From: Roeland Jago Douma Date: Fri, 16 Oct 2015 09:27:02 +0200 Subject: When sharing with the owner show the path The error message should contain the path that is being shared not the numeric id. --- tests/lib/share/share.php | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) (limited to 'tests/lib') diff --git a/tests/lib/share/share.php b/tests/lib/share/share.php index fc1357fe6e7..dc716e898e7 100644 --- a/tests/lib/share/share.php +++ b/tests/lib/share/share.php @@ -1735,6 +1735,30 @@ class Test_Share extends \Test\TestCase { ); $this->assertCount(4, $res); } + + public function testShareWithOwnerError() { + OC_User::setUserId($this->user1); + $view = new \OC\Files\View('/' . $this->user1 . '/'); + $view->mkdir('files/folder1'); + + $fileInfo = $view->getFileInfo('files/folder1'); + $this->assertInstanceOf('\OC\Files\FileInfo', $fileInfo); + $fileId = $fileInfo->getId(); + + $this->assertTrue( + OCP\Share::shareItem('folder', $fileId, OCP\Share::SHARE_TYPE_USER, $this->user2, \OCP\Constants::PERMISSION_ALL), + 'Failed asserting that user 1 successfully shared "test" with user 2.' + ); + + OC_User::setUserId($this->user1); + + try { + OCP\Share::shareItem('folder', $fileId, OCP\Share::SHARE_TYPE_USER, $this->user1, \OCP\Constants::PERMISSION_ALL); + $this->fail(); + } catch (\Exception $e) { + $this->assertEquals('Sharing /folder1 failed, because the user ' . $this->user1 . ' is the item owner', $e->getMessage()); + } + } } class DummyShareClass extends \OC\Share\Share { -- cgit v1.2.3