From 01dbd22c9c2347fffc28240e4a1bd9ccf509a24b Mon Sep 17 00:00:00 2001 From: Vincent Petry Date: Thu, 12 May 2022 13:58:18 +0200 Subject: Validate requested length is random string generator Signed-off-by: Vincent Petry --- tests/lib/Security/SecureRandomTest.php | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/lib/Security/SecureRandomTest.php b/tests/lib/Security/SecureRandomTest.php index 7257d52e8f5..c7ee76a96bb 100644 --- a/tests/lib/Security/SecureRandomTest.php +++ b/tests/lib/Security/SecureRandomTest.php @@ -16,7 +16,6 @@ use OC\Security\SecureRandom; class SecureRandomTest extends \Test\TestCase { public function stringGenerationProvider() { return [ - [0, 0], [1, 1], [128, 128], [256, 256], @@ -77,4 +76,20 @@ class SecureRandomTest extends \Test\TestCase { $matchesRegex = preg_match('/^'.$chars.'+$/', $randomString); $this->assertSame(1, $matchesRegex); } + + public static function invalidLengths() { + return [ + [0], + [-1], + ]; + } + + /** + * @dataProvider invalidLengths + */ + public function testInvalidLengths($length) { + $this->expectException(\LengthException::class); + $generator = $this->rng; + $generator->generate($length); + } } -- cgit v1.2.3